Skip to content

Commit

Permalink
Add some TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
jnjackins committed Sep 26, 2018
1 parent f2ddea9 commit 2150c7f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions reader.go
Original file line number Diff line number Diff line change
@@ -1330,6 +1330,7 @@ func (r *Reader) ReadLag(ctx context.Context) (lag int64, err error) {
// Offset returns the current offset of the reader.
func (r *Reader) Offset() int64 {
if r.useConsumerGroup() {
// TODO: Is this an error value? Or LastOffset?
return -1
}

@@ -1345,6 +1346,7 @@ func (r *Reader) Offset() int64 {
// Lag returns the lag of the last message returned by ReadMessage.
func (r *Reader) Lag() int64 {
if r.useConsumerGroup() {
// TODO: Is this an error value? Or LastOffset?
return -1
}

0 comments on commit 2150c7f

Please sign in to comment.