Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: $removeparam #4528

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

feat: $removeparam #4528

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
94f5868
feat: `$removeparam`
seia-soto Dec 13, 2024
29e9c39
fix: check `parametersRemoved` to prevent infinite loop
seia-soto Dec 13, 2024
3ec1181
fix: parsing and restoration
seia-soto Dec 13, 2024
fd43ad1
feat: removeparam without option value
seia-soto Dec 13, 2024
9497047
refactor: drop use of URLSearchParams
seia-soto Dec 25, 2024
56f90cc
feat: introduce `NetworkFilter.prototype.isRedirectable`
seia-soto Dec 25, 2024
47b1302
refactor: improve matching search param key
seia-soto Dec 25, 2024
7ea4488
test: removeparam
seia-soto Dec 27, 2024
29e9022
test: removeparam removes parameter sequentially
seia-soto Dec 27, 2024
3cb0861
fix(test): unintentional isRedirectable definition
seia-soto Dec 27, 2024
9c1e12b
refactor: use `URL` constructor
seia-soto Jan 6, 2025
c8da3bb
refactor: clarify `removeparam` getter
seia-soto Jan 6, 2025
533110e
refactor: move heavy calls to `before`
seia-soto Jan 14, 2025
1c07025
fix(test): invalid scopes
seia-soto Jan 15, 2025
90d051b
refactor: remove url transforms outside of before hook
seia-soto Jan 15, 2025
ec917aa
fix: removeparam exception
seia-soto Jan 16, 2025
c1db908
fix(test): make global removeparam work with malformed urls
seia-soto Jan 16, 2025
d48fe63
fix(test): correct bucket location
seia-soto Jan 16, 2025
88f35a1
fix: convert to unsigned int on set
seia-soto Jan 23, 2025
160febd
fix: convert to unsigned int on bit clear
seia-soto Jan 23, 2025
4040a89
fix: modify mask safely when applying cpt mask
seia-soto Jan 23, 2025
90ce5c2
fix: make mask unsigned at the end of parse
seia-soto Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: modify mask safely when applying cpt mask
  • Loading branch information
@seia-soto
seia-soto committed Jan 23, 2025
commit 4040a894ba40f212790ef6c7a6567b42c444c5c9
1 change: 1 addition & 0 deletions packages/adblocker/src/filters/network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,7 @@ export default class NetworkFilter implements IFilter {
} else {
mask |= cptMaskPositive & cptMaskNegative;
}
mask >>>= 0;

// Identify kind of pattern
let filter: string | undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/adblocker/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function setBit(n: number, mask: number): number {
}

export function clearBit(n: number, mask: number): number {
return (n & ~mask) >>> 0;
return n & ~mask;
}

export function fastHashBetween(str: string, begin: number, end: number): number {
Expand Down
Loading