Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bitflags' contains_unknown_bits check #6967

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Use bitflags' contains_unknown_bits check #6967

merged 1 commit into from
Jan 22, 2025

Conversation

cwfitzgerald
Copy link
Member

Closes #6914

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 21, 2025 20:58
@cwfitzgerald
Copy link
Member Author

cwfitzgerald commented Jan 21, 2025 •
edited
Loading

This needed bitflag version already landed in moz's tree, so no fret here.

@ErichDonGubler ErichDonGubler changed the title Use Bitflags Unknown Bit Check Use bitflags' contains_unknown_bits check Jan 22, 2025
ErichDonGubler
ErichDonGubler approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minus the (lack of) CHANGELOG entry; I think this is an important breaking change to announce, since folks might have been relying on the other bits being ignored until now.

@ErichDonGubler ErichDonGubler self-assigned this Jan 22, 2025
@cwfitzgerald
Copy link
Member Author

Maybe it should be added for the last release, but this is what the code it replaced does, there's just a nice method for it now.

@cwfitzgerald cwfitzgerald merged commit 3dd925b into gfx-rs:trunk Jan 22, 2025
31 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/unknown-bit-check branch January 22, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErichDonGubler ErichDonGubler ErichDonGubler approved these changes

Assignees

@ErichDonGubler ErichDonGubler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up bitflag unknown bit contain checks
2 participants
@cwfitzgerald @ErichDonGubler