Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Short Circuting GL Fences #6942

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jan 18, 2025

Connections

Prerequisite #4589

Description

Allow GL Fences to be put into a "short circuiting" mode where they immediately

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@cwfitzgerald cwfitzgerald requested review from crowlKats and a team as code owners January 18, 2025 01:27
@cwfitzgerald cwfitzgerald force-pushed the cw/gl-auto-resolve branch 2 times, most recently from ac3e292 to 058bc16 Compare January 18, 2025 02:16
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost forgot about this story, thanks for picking this up again! 🙇
Very happy how the backend specific options play out here now

The old code's atomics make me nervous but way cleaner than before (and much easier to reason about this sort of thing now)

wgpu-hal/examples/ray-traced-triangle/main.rs Outdated Show resolved Hide resolved
wgpu-types/src/instance.rs Outdated Show resolved Hide resolved
wgpu-hal/src/gles/fence.rs Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald enabled auto-merge (squash) January 21, 2025 19:19
@cwfitzgerald cwfitzgerald merged commit a1fc4a0 into gfx-rs:trunk Jan 21, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants