Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Flush to GL Queue::submit #6941

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Add Flush to GL Queue::submit #6941

merged 1 commit into from
Jan 18, 2025

Conversation

cwfitzgerald
Copy link
Member

Quick one, related to #4589's work - make sure we flush gl commands.

@cwfitzgerald cwfitzgerald requested a review from a team as a code owner January 17, 2025 20:13
Wumpf
Wumpf approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, great catch. Makes sense to me after reading docs for gl flush again.
Do you have any piece of doc to link to for the flushing on headless, or just based on experience?

@cwfitzgerald
Copy link
Member Author

Just encountered this when getting to fix the timeout stuff and had to get Kelsey to tell me why nothing was working lol

@cwfitzgerald cwfitzgerald merged commit dcdb103 into gfx-rs:trunk Jan 18, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwfitzgerald @Wumpf