[naga] implement pointer_composite_access WGSL language extension
#6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
sagudev
force-pushed
the
pointer_composite_access
branch
2 times, most recently
from
00a89cb to
1f6c1e8
Compare
sagudev
changed the title
pointer_composite_access extensionpointer_composite_access WGSL language extension
sagudev
changed the title
pointer_composite_access WGSL language extensionpointer_composite_access WGSL language extension
|
Happy to take a crack at reviewing this in the next couple of days. |
|
I think I'm going to be able to review this on Tuesday of this coming week. 🫡 See you then! |
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
ErichDonGubler
force-pushed
the
pointer_composite_access
branch
from
9ac9516 to
01ee86e
Compare
ErichDonGubler
approved these changes
Jan 23, 2025
Open
3 tasks
|
PR in servo: servo/servo#35161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fix #6192
Description
Implementd
pointer_composite_accessWGSL language extension, by removing:wgpu/naga/src/front/wgsl/error.rs
Line 216 in 3036413
and replacing it with code that maps declares pointer as references.
fc3503a is not standalone as tests are fixed in next commit, but it's reviewable per commit.
PR in servo: servo/servo#35161
Testing
CTS run in servo and added tests. Servo changes (contain expectation changes in two commits, first on enabled extension second one on implemented extension): servo/servo@main...sagudev:servo:pointer_composite_access. Related uniformity test are also failing in firefox nightly so this seems to be another naga problem and first expectation is now fixed on trunk by #6920
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.