Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spv-in parse AtomicLoad and AtomicStore #5821

Closed

Conversation

schell
Copy link
Contributor

@schell schell commented Jun 15, 2024

Connections
Part of:

Depends on:

Requires rebase after #5775 merges.

Description

This adds parsing to front::spv::Frontend::next_block for atomic load and atomic store operations.

Testing

  • added manual test to atomic_upgrade.rs
  • added snapshot test

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@schell schell mentioned this pull request Jun 15, 2024
@schell schell changed the title spirv-in parse AtomicLoad and AtomicStore spv-in parse AtomicLoad and AtomicStore Jun 16, 2024
@schell schell mentioned this pull request Jun 16, 2024
6 tasks
@schell schell force-pushed the feature/spirv-front-atomics-3-load-and-store branch from 4c53b3a to b9a6591 Compare June 16, 2024 19:12
@schell
Copy link
Contributor Author

schell commented Jun 16, 2024

Closing in favor of #5824

@schell schell closed this Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants