-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spv-in parse AtomicLoad and AtomicStore #5821
Closed
schell
wants to merge
27
commits into
gfx-rs:trunk
from
schell:feature/spirv-front-atomics-3-load-and-store
Closed
spv-in parse AtomicLoad and AtomicStore #5821
schell
wants to merge
27
commits into
gfx-rs:trunk
from
schell:feature/spirv-front-atomics-3-load-and-store
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feature/spirv-front-atomics-2
schell
changed the title
spirv-in parse AtomicLoad and AtomicStore
spv-in parse AtomicLoad and AtomicStore
Jun 16, 2024
schell
force-pushed
the
feature/spirv-front-atomics-3-load-and-store
branch
from
June 16, 2024 19:12
4c53b3a
to
b9a6591
Compare
Closing in favor of #5824 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Part of:
Depends on:
Requires rebase after #5775 merges.
Description
This adds parsing to
front::spv::Frontend::next_block
for atomic load and atomic store operations.Testing
atomic_upgrade.rs
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.