Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifetime constraints from wgpu::ComputePass methods #5570

Merged
merged 12 commits into from
May 14, 2024
Merged

Remove lifetime constraints from wgpu::ComputePass methods #5570

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d12ba2c
basic test setup
Wumpf Mar 24, 2024
a86ef5c
remove lifetime and drop resources on test - test fails now just as e…
Wumpf Mar 24, 2024
e39fa3b
compute pass recording is now hub dependent (needs gfx_select)
Wumpf Mar 24, 2024
8af13df
compute pass recording now bumps reference count of uses resources di…
Wumpf Mar 30, 2024
2673628
simplify compute pass state flush, compute pass execution no longer n…
Wumpf Apr 19, 2024
a88a906
wgpu sided error handling
Wumpf Apr 19, 2024
841cfcb
make ComputePass hal dependent, removing command cast hack. Introduce…
Wumpf Apr 20, 2024
4f3f1db
remove stray repr(C)
Wumpf Apr 20, 2024
5bfef4b
changelog entry
Wumpf Apr 20, 2024
0d470a9
fix deno issues -> move DynComputePass into wgc
Wumpf Apr 20, 2024
22c1e68
split out resources setup from test
Wumpf Apr 21, 2024
acc3a04
Merge remote-tracking branch 'origin/trunk' into lifetime-free-comput…
Wumpf May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove stray repr(C)
  • Loading branch information
@Wumpf
Wumpf committed Apr 23, 2024
commit 4f3f1db8799d2d7b910571ef21744564af39d7e5
1 change: 0 additions & 1 deletion wgpu-core/src/command/compute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ impl<A: HalApi> fmt::Debug for ComputePass<A> {
}

/// Describes the writing of timestamp values in a compute pass.
#[repr(C)]
#[derive(Clone, Debug, PartialEq, Eq)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub struct ComputePassTimestampWrites {
Expand Down