Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bgra8unorm-storage #4228

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Add support for bgra8unorm-storage #4228

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ad1b9da
Add `BGRA8UNORM_STORAGE` extension
jinleili Sep 17, 2023
3e72bd6
Check for the feature in create_texture
nical Oct 6, 2023
ba7949f
Leave a comment in the backends that don't support bgra8unorm-storage
nical Oct 6, 2023
9beab65
Pass the appropriate storage format to naga
nical Oct 6, 2023
44acb8e
Check for bgra8unorm storage support in the vulkan backend
nical Oct 10, 2023
6007cf5
Add a test
nical Oct 10, 2023
848fb84
Don't validate twice
nical Oct 11, 2023
8667aa6
Prettier vk descriptor initialization
nical Oct 11, 2023
300829a
Better document the vk queries
nical Oct 11, 2023
c366c47
Add a changelog entry
nical Oct 11, 2023
19d26c4
Remove outdated comment
nical Oct 11, 2023
981dc24
Update wgpu-hal/src/vulkan/adapter.rs
nical Oct 11, 2023
d7bab55
Add the extension enum variant in deno
nical Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update wgpu-hal/src/vulkan/adapter.rs 
Co-authored-by: Teodor Tanasoaia <28601907+teoxoy@users.noreply.github.com>
  • Loading branch information
@nical @teoxoy
nical and teoxoy committed Oct 12, 2023
commit 981dc24ff927435fb1fdc7efa381bee1533cb6ab
7 changes: 2 additions & 5 deletions wgpu-hal/src/vulkan/adapter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1784,10 +1784,7 @@ fn supports_bgra8unorm_storage(
let features2 = properties2.format_properties.optimal_tiling_features;
let features3 = properties3.optimal_tiling_features;

let base_requirements = features2.contains(vk::FormatFeatureFlags::STORAGE_IMAGE);
let vk_1_3_reequirements =
features3.contains(vk::FormatFeatureFlags2::STORAGE_WRITE_WITHOUT_FORMAT_KHR);

base_requirements && vk_1_3_reequirements
features2.contains(vk::FormatFeatureFlags::STORAGE_IMAGE)
&& features3.contains(vk::FormatFeatureFlags2::STORAGE_WRITE_WITHOUT_FORMAT)
}
}