Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details to InstanceError and CreateSurfaceError. #4066

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Add details to InstanceError and CreateSurfaceError. #4066

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cd0f99c
Add details to `InstanceError` and `CreateSurfaceError`.
kpreid Aug 16, 2023
41fe862
Fix DXGI error type handling
kpreid Aug 16, 2023
93f52c7
fix fmt::Debug path with expose-ids
kpreid Aug 16, 2023
42cecb6
Fix typo affecting Android only
kpreid Aug 16, 2023
313f1b2
Test `create_surface_from_canvas()` error.
kpreid Aug 21, 2023
0ccf7f0
Merge branch 'trunk' into error
cwfitzgerald Aug 22, 2023
eebd9b6
Ignore false positive `redundant_clone` from Clippy
kpreid Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Ignore false positive redundant_clone from Clippy
  • Loading branch information
@kpreid
kpreid committed Aug 22, 2023
commit eebd9b67d5b2638a121b9f5a9bd04a1744c016fe
1 change: 1 addition & 0 deletions tests/tests/create_surface_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ fn canvas_get_context_returned_null() {
// Using a context id that is not "webgl2" or "webgpu" will render the canvas unusable by wgpu.
canvas_g.canvas.get_context("2d").unwrap();

#[allow(clippy::redundant_clone)] // false positive — can't and shouldn't move out.
let error = instance
.create_surface_from_canvas(canvas_g.canvas.clone())
.unwrap_err();
Expand Down