Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PyPy3.5 5.7.1 #965

Merged
merged 10 commits into from
Apr 7, 2017
Prev Previous commit
Next Next commit
another blackballed test due to performance issues.
  • Loading branch information
jamadden committed Apr 6, 2017
commit 32c2e0f2329e2c58bbe3b19e914e1419e9a41466
3 changes: 2 additions & 1 deletion src/gevent/_socket3.py
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,8 @@ def sendall(self, data, flags=0):
# XXX Now that we run on PyPy3, see the notes in _socket2.py's sendall()
# and implement that here if needed.
# PyPy3 is not optimized for performance yet, and is known to be slower than
# PyPy2, so it's probably premature to do this.
# PyPy2, so it's possibly premature to do this. However, there is a 3.5 test case that
# possibly exposes this in a severe way.
data_memory = _get_memory(data)
len_data_memory = len(data_memory)
if not len_data_memory:
Expand Down
5 changes: 5 additions & 0 deletions src/greentest/patched_tests_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,11 @@ def get_switch_expected(fullname):
disabled_tests += [
# This fails to close all the FDs, at least on CI
'test_subprocess.POSIXProcessTestCase.test_close_fds_when_max_fd_is_lowered',
# we have n^2 behaviour for socket.sendall on partial writes,
# and this tests tries to send a large amount of data and provoke partial writes.
# We fixed this is python 2 and need to do so for Python 3 (if it's the same
# thing; it may not be, this is just supposition)
'test_wsgiref.IntegrationTests.test_interrupted_write',
]

if TRAVIS:
Expand Down