Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Inky theme #106

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Added Inky theme #106

merged 2 commits into from
Sep 15, 2023

Conversation

jimmyff
Copy link
Contributor

@jimmyff jimmyff commented Feb 2, 2023

No description provided.

@Keats
Copy link
Collaborator

Keats commented Feb 6, 2023

Have you figured out all the issues with your site with the next branch of Zola?

@Jieiku
Copy link
Contributor

Jieiku commented Feb 7, 2023

Clean looking theme, looks like it may be affected by the bug I reported here: getzola/zola#1856

@jimmyff
Copy link
Contributor Author

jimmyff commented Feb 9, 2023

@Keats ah no I didn't know that was a thing, I'll get it working with the next build. As there are breaking changes mentioned how can I specify the theme's minimum zola version? Maybe a zola_version would be a good addition to the config?

@Jieiku thanks for flagging that, I'll look through the fix you've linked me to and update as required!

@Keats
Copy link
Collaborator

Keats commented Feb 9, 2023

There is min_version: https://www.getzola.org/documentation/themes/creating-a-theme/

@jimmyff
Copy link
Contributor Author

jimmyff commented Feb 9, 2023

There is min_version: https://www.getzola.org/documentation/themes/creating-a-theme/

🤦‍♂️ thanks! ☺️

@jimmyff
Copy link
Contributor Author

jimmyff commented Feb 12, 2023

Hey @Keats I've made it compatible with the next branch but I'm struggling to get the build working. I've tried to set this in my deploy script: uses: shalzz/zola-deploy-action@next but it's not happy:
https://github.com/jimmyff/zola-inky/actions/runs/4157851465/jobs/7192645103

@Keats
Copy link
Collaborator

Keats commented Feb 13, 2023

The action only works with released version of zola.
I'll release 0.17 this week so wait a bit

@Keats Keats merged commit 7434f42 into getzola:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants