Skip to content

Commit

Permalink
fix some formatting issues with the roadmap
Browse files Browse the repository at this point in the history
  • Loading branch information
pbakaus committed Jul 9, 2018
1 parent 08be92b commit 0055759
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
12 changes: 10 additions & 2 deletions assets/sass/pages/_roadmap.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
text-align: center;

h4,
p {
p,
ul:not(.tags) {
color: $color-white;
margin: 0 0 5px 0;
}
Expand Down Expand Up @@ -83,12 +84,19 @@
font-weight: 400;
}

p {
p,
ul:not(.tags) {
margin-top: 0;
font-size: 10pt;
line-height: 1.5;
color: #444;
}

ul:not(.tags) {
padding-left: 1.1em;
list-style-type: square;
}

}

}
Expand Down
6 changes: 3 additions & 3 deletions content/includes/roadmap.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"issue": {
"url": "https://github.com/ampproject/amphtml/issues/16555",
"title": "Instrument & tweak legacy ad performance with no impact to UX",
"description": "- [ ] Legacy ads (ads that consist of JS) on AMP pages some times have indeterministic behavior in regards to how quickly they appear on screen. This can happen in two different situations: 1) When the AMP page loads and looks entirely loaded by the ads take close to 5-6 seconds to load 2) Ads further down the viewport (even within 5 viewports) are not rendered even when scrolling down 10 seconds after pausing in the first viewport. ",
"description": "- Legacy ads (ads that consist of JS) on AMP pages some times have indeterministic behavior in regards to how quickly they appear on screen. This can happen in two different situations: 1) When the AMP page loads and looks entirely loaded by the ads take close to 5-6 seconds to load 2) Ads further down the viewport (even within 5 viewports) are not rendered even when scrolling down 10 seconds after pausing in the first viewport. ",
"labels": [
{
"url": "https://api.github.com/repos/ampproject/amphtml/labels/Category:%20Ads",
Expand Down Expand Up @@ -151,7 +151,7 @@
"issue": {
"url": "https://github.com/ampproject/amphtml/issues/16535",
"title": "Add new analytics for stories",
"description": "- [ ] Add an analytics trigger for when the user education overlay is shown (#15420)\r\n- [ ] Add an analytics trigger for when the video spinner is shown",
"description": "- Add an analytics trigger for when the user education overlay is shown (#15420)\r\n- Add an analytics trigger for when the video spinner is shown",
"labels": [
{
"url": "https://api.github.com/repos/ampproject/amphtml/labels/Category:%20AMP%20Story",
Expand Down Expand Up @@ -209,7 +209,7 @@
"issue": {
"url": "https://github.com/ampproject/amphtml/issues/16533",
"title": "Design/test a new desktop experience for stories",
"description": "- [ ] Create a prototype of a new desktop experience\r\n- [ ] Test the prototype\r\n- [ ] Integrate feedback\r\n- [ ] Design a launch/rollout plan\r\n- [ ] Roll out the new desktop experience",
"description": "- Create a prototype of a new desktop experience\r\n- Test the prototype\r\n- Integrate feedback\r\n- Design a launch/rollout plan\r\n- Roll out the new desktop experience",
"labels": [
{
"url": "https://api.github.com/repos/ampproject/amphtml/labels/Category:%20AMP%20Story",
Expand Down
5 changes: 4 additions & 1 deletion scripts/import_roadmap.js
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ async function importRoadmap() {
card.issue = {
url: issue.data.html_url,
title: issue.data.title.replace(/\[Master [fF]eature\] /, ''),
description: issue.data.body.replace('Feature description:\r\n\r\n', '').split('\r\n\r\n')[0],
description: issue.data.body
.replace('Feature description:\r\n\r\n', '')
.replace(/\[ \]/g, '')
.split('\r\n\r\n')[0],
labels: (issue.data.labels || []).map(label => {

return label.name.startsWith('Category:') ? { url: label.url, name: label.name.replace('Category:', ''), color: label.color } : false;
Expand Down

0 comments on commit 0055759

Please sign in to comment.