-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support referencing AWS KMS keys by aliases #415
Conversation
- addresses issue #381
cc @snstanton |
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=========================================
Coverage ? 43.38%
=========================================
Files ? 16
Lines ? 2206
Branches ? 0
=========================================
Hits ? 957
Misses ? 1160
Partials ? 89
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I'm curious why you prefer using aliases vs the full ARN, though. They seem to be about as hard (read: impossible) to memorize as the ARN, since you'd have to memorize the account id, right?
We have multiple environments, each with its own set of keys. When we generate the key we use the environment name as the alias. This makes it very easy to configure sops since our tooling can derive the list of keys. |
I see, good to know! |
It's not just that: when the key rotates, the ID changes and you have to adjust the SOPS file. However, with an alias, this change is obsolete as the alias automatically points to the new (rotated) ID. |
what
Allow KMS keys to be referenced by alias instead of the complete ARN
Example use:
why
Addresses issue #381
testing
Unit tests are passing, its not clear how to run the functional tests