-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement profile chunk storage #463
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" | ||
| "errors" | ||
| "io" | ||
| "net/http" | ||
| "strconv" | ||
|
|
||
| "github.com/getsentry/sentry-go" | ||
| "github.com/segmentio/kafka-go" | ||
| "gocloud.dev/gcerrors" | ||
|
|
||
| "github.com/getsentry/vroom/internal/chunk" | ||
| "github.com/getsentry/vroom/internal/storageutil" | ||
| ) | ||
|
|
||
| func (env *environment) postChunk(w http.ResponseWriter, r *http.Request) { | ||
| ctx := r.Context() | ||
| hub := sentry.GetHubFromContext(ctx) | ||
|
|
||
| s := sentry.StartSpan(ctx, "processing") | ||
| s.Description = "Read HTTP body" | ||
| body, err := io.ReadAll(r.Body) | ||
| s.Finish() | ||
| if err != nil { | ||
| hub.CaptureException(err) | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| return | ||
| } | ||
| defer r.Body.Close() | ||
|
|
||
| c := new(chunk.Chunk) | ||
| s = sentry.StartSpan(ctx, "json.unmarshal") | ||
| s.Description = "Unmarshal profile" | ||
| err = json.Unmarshal(body, c) | ||
| s.Finish() | ||
| if err != nil { | ||
| hub.CaptureException(err) | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| return | ||
| } | ||
|
|
||
| hub.Scope().SetContext("Profile metadata", map[string]interface{}{ | ||
| "chunk_id": c.ID, | ||
| "organization_id": strconv.FormatUint(c.OrganizationID, 10), | ||
| "profiler_id": c.ProfilerID, | ||
| "project_id": strconv.FormatUint(c.ProjectID, 10), | ||
| "size": len(body), | ||
| }) | ||
|
|
||
| hub.Scope().SetTags(map[string]string{ | ||
| "platform": string(c.Platform), | ||
| }) | ||
|
|
||
| s = sentry.StartSpan(ctx, "gcs.write") | ||
| s.Description = "Write profile to GCS" | ||
| err = storageutil.CompressedWrite(ctx, env.storage, c.StoragePath(), body) | ||
| s.Finish() | ||
| if err != nil { | ||
| if errors.Is(err, context.DeadlineExceeded) { | ||
| // This is a transient error, we'll retry | ||
| w.WriteHeader(http.StatusTooManyRequests) | ||
| } else { | ||
| // These errors won't be retried | ||
| hub.CaptureException(err) | ||
| if code := gcerrors.Code(err); code == gcerrors.FailedPrecondition { | ||
| w.WriteHeader(http.StatusPreconditionFailed) | ||
| } else { | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| } | ||
| } | ||
| return | ||
| } | ||
|
|
||
| s = sentry.StartSpan(ctx, "json.marshal") | ||
| s.Description = "Marshal chunk Kafka message" | ||
| b, err := json.Marshal(buildChunkKafkaMessage(c)) | ||
| s.Finish() | ||
| if err != nil { | ||
| hub.CaptureException(err) | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| return | ||
| } | ||
| s = sentry.StartSpan(ctx, "processing") | ||
| s.Description = "Send chunk to Kafka" | ||
| err = env.profilingWriter.WriteMessages(ctx, kafka.Message{ | ||
| Topic: env.config.ProfileChunksKafkaTopic, | ||
| Value: b, | ||
| }) | ||
| if err != nil { | ||
| hub.CaptureException(err) | ||
| w.WriteHeader(http.StatusInternalServerError) | ||
| return | ||
| } | ||
| s.Finish() | ||
|
|
||
| w.WriteHeader(http.StatusNoContent) | ||
| } | ||
|
|
||
| type ( | ||
| ChunkKafkaMessage struct { | ||
| ProjectID uint64 `json:"project_id"` | ||
| ProfilerID string `json:"profiler_id"` | ||
| ChunkID string `json:"chunk_id"` | ||
|
|
||
| StartTimestamp float64 `json:"start_timestamp"` | ||
| EndTimestamp float64 `json:"end_timestamp"` | ||
|
|
||
| Received float64 `json:"received"` | ||
| RetentionDays int `json:"retention_days"` | ||
| } | ||
| ) | ||
|
|
||
| func buildChunkKafkaMessage(c *chunk.Chunk) *ChunkKafkaMessage { | ||
| start, end := c.StartEndTimestamps() | ||
| return &ChunkKafkaMessage{ | ||
| ChunkID: c.ID, | ||
| ProjectID: c.ProjectID, | ||
| ProfilerID: c.ProfilerID, | ||
| StartTimestamp: start, | ||
| EndTimestamp: end, | ||
| Received: c.Received, | ||
| RetentionDays: c.RetentionDays, | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| package chunk | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| "github.com/getsentry/vroom/internal/debugmeta" | ||
| "github.com/getsentry/vroom/internal/frame" | ||
| "github.com/getsentry/vroom/internal/platform" | ||
| ) | ||
|
|
||
| type ( | ||
| // Chunk is an implementation of the Sample V2 format. | ||
| Chunk struct { | ||
| ID string `json:"chunk_id"` | ||
| ProfilerID string `json:"profiler_id"` | ||
|
|
||
| DebugMeta debugmeta.DebugMeta `json:"debug_meta"` | ||
|
|
||
| Environment string `json:"environment"` | ||
| Platform platform.Platform `json:"platform"` | ||
| Release string `json:"release"` | ||
|
|
||
| Version string `json:"version"` | ||
|
|
||
| Profile Data `json:"profile"` | ||
|
|
||
| OrganizationID uint64 `json:"organization_id"` | ||
| ProjectID uint64 `json:"project_id"` | ||
| Received float64 `json:"received"` | ||
| RetentionDays int `json:"retention_days"` | ||
|
|
||
| Measurements json.RawMessage | ||
| } | ||
|
|
||
| Data struct { | ||
| Frames []frame.Frame | ||
| Samples []Sample | ||
| Stacks [][]int | ||
| ThreadMetadata map[string]map[string]string `json:"thread_metadata"` | ||
| } | ||
|
|
||
| Sample struct { | ||
| StackID int `json:"stack_id"` | ||
| ThreadID string `json:"thread_id"` | ||
| Timestamp float64 | ||
| } | ||
| ) | ||
|
|
||
| func (c *Chunk) StoragePath() string { | ||
| return fmt.Sprintf( | ||
| "%d/%d/%s/%s", | ||
| c.OrganizationID, | ||
| c.ProjectID, | ||
| c.ProfilerID, | ||
| c.ID, | ||
| ) | ||
| } | ||
|
|
||
| func (c *Chunk) StartEndTimestamps() (float64, float64) { | ||
| count := len(c.Profile.Samples) | ||
| if count == 0 { | ||
| return 0, 0 | ||
| } | ||
| return c.Profile.Samples[0].Timestamp, c.Profile.Samples[count-1].Timestamp | ||
phacops marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought but can we emit this as a metric to see the average payload size by platform?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll wait until @viglia is done with implementing metrics then. Maybe you can even beta test on this.