Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: View Hierarchy #1169

Merged
merged 38 commits into from
Mar 10, 2023
Merged

feat: View Hierarchy #1169

merged 38 commits into from
Mar 10, 2023

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Feb 6, 2023

Requires getsentry/sentry-dotnet#2163 on the .NET SDK

View Hierarchy is an opt-in feature that captures the scene hierarchy at the moment of an event and attaches it as an attachment.
The hierarchy also contains a list of all components on all captured game objects.

ViewHierarchy_Options

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 3ccdd30

@bitsandfoxes bitsandfoxes mentioned this pull request Feb 15, 2023
3 tasks
@bitsandfoxes bitsandfoxes requested review from bruno-garcia, vaind and mattjohnsonpint and removed request for bruno-garcia March 2, 2023 16:38
@bitsandfoxes bitsandfoxes marked this pull request as ready for review March 2, 2023 16:40
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas and nits. Also dotnet update shouldn't be here.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Sentry.Unity/UnityViewHierarchyAttachmentContent.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/UnityViewHierarchyAttachmentContent.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/SentryUnityOptions.cs Outdated Show resolved Hide resolved
src/Sentry.Unity/UnityViewHierarchyAttachmentContent.cs Outdated Show resolved Hide resolved
@bitsandfoxes
Copy link
Contributor Author

I updated the description about the requirement on the .NET SDK. It's either main or waiting for a new release. Let's see what comes first.

@bitsandfoxes bitsandfoxes requested a review from vaind March 6, 2023 11:32
@bitsandfoxes bitsandfoxes merged commit 9ebf67e into main Mar 10, 2023
@bitsandfoxes bitsandfoxes deleted the feat/viewhierarchy branch March 10, 2023 13:15
@bruno-garcia
Copy link
Member

Nice! Looking forward to the GDC where you show this off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants