feat(core)!: Stop accepting event as argument for recordDroppedEvent
#14999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/drop-event-overload
branch
from
83f3f32 to
36b389c
Compare
lforst
approved these changes
Jan 14, 2025
mydea
force-pushed
the
fn/drop-event-overload
branch
from
36b389c to
1e4a6dc
Compare
The event was no longer used for some time, instead you can (optionally) pass a count of dropped events as third argument. This has been around since v7, so we can finally clean this up here.
mydea
force-pushed
the
fn/drop-event-overload
branch
from
1e4a6dc to
c07dc67
Compare
AbhiPrasad
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event was no longer used for some time, instead you can (optionally) pass a count of dropped events as third argument. This has been around since v7, so we can finally clean this up here, which should also save some bytes.
This was not really deprecated before, but is also more an intimate API so I do not expect this to affect users too much. Also, deprecating arguments like this does not really work well with eslint anyhow, so even if we would deprecate it it is unlikely users would find out anyhow.