chore(nextjs): Fix optional chaining linting issue #14982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
approved these changes
Jan 13, 2025
mydea
reviewed
Jan 13, 2025
| .map((str: string) => str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')) | ||
| : []; | ||
|
|
||
| const reexport = reexportMatch?.[1] |
There was a problem hiding this comment.
l: This is fine this way, but can also be rewritten now to:
const wrap = wrapMatch?.[1]
?.split(',')
.filter(param => param !== '')
// Sanitize, as code could be injected with another rollup plugin
.map((str: string) => str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'))
|| [];
mydea
changed the title
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a strange one, maybe caused by caching?
The last few PRs are failing due to these linting issues but I can't reproduce this locally on
developand it looks like everything passed in CI 🤷♂️