-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use BCSymbolMaps for processing dSYMs #973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upload BCSymbolMaps from the xcarchive to Sentry.
App Store connect requires a period-separated list of at most three non-negative integers for the version. Therefore the version bump script must not add the suffixes of preview releases. This is fixed now.
…y/sentry-cocoa into ci/fix-app-store-connect-upload
bruno-garcia
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use Fastlane to process the dSYMs with BCSymbolMaps so we get proper stacktraces in Sentry.
This PR is based on #972.
💡 Motivation and Context
We have bitcode enabled for the iOS-Swift sample app and function names are hidden in Sentry, see https://sentry.io/share/issue/2a6a4acd095b42abb85f690d91352cad/.
💚 How did you test it?
CI and with sample app in Testflight.
📝 Checklist
🔮 Next steps