Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use BCSymbolMaps for processing dSYMs #973

Merged
merged 32 commits into from
Mar 4, 2021

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Mar 3, 2021

📜 Description

Use Fastlane to process the dSYMs with BCSymbolMaps so we get proper stacktraces in Sentry.

This PR is based on #972.

💡 Motivation and Context

We have bitcode enabled for the iOS-Swift sample app and function names are hidden in Sentry, see https://sentry.io/share/issue/2a6a4acd095b42abb85f690d91352cad/.

💚 How did you test it?

CI and with sample app in Testflight.

📝 Checklist

  • I reviewed the submitted code
  • I updated the CHANGELOG if needed
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@philipphofmann philipphofmann requested a review from a team March 3, 2021 10:33
@philipphofmann philipphofmann self-assigned this Mar 3, 2021
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Base automatically changed from ci/fix-app-store-connect-upload to master March 4, 2021 08:12
@philipphofmann philipphofmann enabled auto-merge (squash) March 4, 2021 08:15
@philipphofmann philipphofmann merged commit a246477 into master Mar 4, 2021
@philipphofmann philipphofmann deleted the ci/upload-bcsymbolmaps branch March 4, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants