ci: Replace not validated GitHub Actions #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced all non validated GitHub Actions by replicating the functionality manually.
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
==========================================
- Coverage 94.73% 94.69% -0.05%
==========================================
Files 76 76
Lines 3494 3504 +10
==========================================
+ Hits 3310 3318 +8
- Misses 184 186 +2
Continue to review full report at Codecov.
|
bruno-garcia
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Replaced all non validated GitHub Actions by replicating the functionality
manually.
💡 Motivation and Context
For uploading the Swift iOS sample app to TestFlight with #918, we added some secrets to the repo that we don't want to be exploited. By removing not validated GitHub Actions we make it harder to steal those secrets.
💚 How did you test it?
CI
📝 Checklist
🔮 Next steps