-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Deploy iOS-Swift to Testflight #918
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5dc0ba9
ci: Deploy iOS-Swift to Testflight
philipphofmann b3e79ae
Merge branch 'master' into ci/fastlane
philipphofmann bf3aba7
Bump version for iOS-Swift
philipphofmann 9df8af5
Minor cleanup
philipphofmann ed92a75
Set ITSAppUsesNonExemptEncryption to NO
philipphofmann ed9028e
Only download latest dSYMs
philipphofmann 7b596d3
Merge branch 'master' into ci/fastlane
philipphofmann 41ede8b
Merge branch 'master' into ci/fastlane
philipphofmann 32282fe
Use API key
philipphofmann d1c8ae8
Update fastlane
philipphofmann 0346b99
Use SPACESHIP_SKIP_2FA_UPGRADE
philipphofmann 3d7df70
Remove CI branch
philipphofmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| name: Upload to Testflight | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| env: | ||
| FASTLANE_KEYCHAIN_NAME: fastlane.keychain | ||
|
|
||
| jobs: | ||
|
|
||
| upload_to_testflight: | ||
| name: Build and Upload iOS-Swift to Testflight | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - run: ./scripts/ci-select-xcode.sh | ||
|
|
||
| # The Github Actions hang when Xcode is trying to sign the app because | ||
| # a modal window pops up to access the signing key's keychain. This modal | ||
| # lets the action hang. A workaround is to create a local keychain and | ||
| # store the signing keys in there. | ||
| # https://github.com/actions/virtual-environments/issues/1820#issuecomment-719549887 | ||
|
|
||
| # Sometimes the keychain already exists | ||
| - name: Delete local keychain | ||
| continue-on-error: true | ||
| run: security delete-keychain $FASTLANE_KEYCHAIN_NAME | ||
|
|
||
| - name: Create local keychain | ||
| run: | | ||
| security create-keychain -p ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }} $FASTLANE_KEYCHAIN_NAME | ||
| security set-keychain-settings -lut 21600 $FASTLANE_KEYCHAIN_NAME | ||
| security unlock-keychain -p ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }} $FASTLANE_KEYCHAIN_NAME | ||
| security list-keychain -d user -s $FASTLANE_KEYCHAIN_NAME | ||
|
|
||
| - uses: actions/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '2.7' | ||
|
|
||
| - name: Setup fastlane | ||
| run: bundle install | ||
|
|
||
| # We upload a new version to TestFlight on every commit on Master | ||
| # So we need to bump the bundle version each time | ||
| - name: Bump Bundle Version | ||
| env: | ||
| FASTLANE_BUNDLE_VERSION: $GITHUB_RUN_NUMBER | ||
| run: bundle exec fastlane bump_bundle_version | ||
| shell: sh | ||
|
|
||
| - name: Run Fastlane | ||
| env: | ||
| APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }} | ||
| APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }} | ||
| APP_STORE_CONNECT_KEY: ${{ secrets.APP_STORE_CONNECT_KEY }} | ||
| FASTLANE_USER: ${{ secrets.FASTLANE_USER }} | ||
| FASTLANE_PASSWORD: ${{ secrets.FASTLANE_PASSWORD }} | ||
| FASTLANE_KEYCHAIN_PASSWORD: ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }} | ||
| MATCH_GIT_PRIVATE_KEY: ${{ secrets.MATCH_GIT_PRIVATE_KEY }} | ||
| MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }} | ||
| MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }} | ||
| SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} | ||
| run: bundle exec fastlane ios_swift_to_testflight | ||
| shell: sh | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,5 @@ source "https://rubygems.org" | |
|
|
||
| gem "bundler", ">= 2" | ||
| gem "cocoapods", ">= 1.9.1" | ||
| gem "fastlane" | ||
| gem "rest-client" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| app_identifier("io.sentry.sample.iOS-Swift") # The bundle identifier of your app | ||
|
|
||
| itc_team_id("96157806") # App Store Connect Team ID | ||
| team_id("97JCY7859U") # Developer Portal Team ID | ||
|
|
||
| # For more information about the Appfile, see: | ||
| # https://docs.fastlane.tools/advanced/#appfile | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these passwords only for the specific test app? What can one do with these secrets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should rather discuss in private what you can do with these secrets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe lets have a secret meeting 🤫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do it over signal :D