ci: Deploy iOS-Swift to Testflight #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
requested changes
Jan 28, 2021
|
|
||
| - name: Create local keychain | ||
| run: | | ||
| security create-keychain -p ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }} $FASTLANE_KEYCHAIN_NAME |
There was a problem hiding this comment.
Are these passwords only for the specific test app? What can one do with these secrets?
There was a problem hiding this comment.
Maybe we should rather discuss in private what you can do with these secrets.
There was a problem hiding this comment.
Maybe lets have a secret meeting 🤫
There was a problem hiding this comment.
let's do it over signal :D
marandaneto
reviewed
Feb 1, 2021
.github/workflows/testflight.yml
Outdated
| push: | ||
| branches: | ||
| - master | ||
| - ci/** # Todo remove before merging |
There was a problem hiding this comment.
H: remove before merging :D
marandaneto
approved these changes
Feb 1, 2021
5 tasks
|
Upload fails because of privacy statement not accepted. According to this issue, all users in TestFlight need to accept the privacy statement. I'm currently pinging everyone and will try again soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Every commit on master triggers a deploy of the iOS-Swift Sample app to Testflight. See it in action here: https://github.com/getsentry/sentry-cocoa/actions?query=workflow%3A%22Upload+to+Testflight%22
💡 Motivation and Context
We want to be able to test a real-world scenario use of our SDK on a regular basis.
💚 How did you test it?
Downloading the build via Testflight.
📝 Checklist
🔮 Next steps