ref: fix some types for sentry.issues (#72813)

getsentry · Jun 17, 2024 · fcb6eef · fcb6eef
1 parent 79a804e
commit fcb6eef
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/src/sentry/issues/attributes.py b/src/sentry/issues/attributes.py
@@ -153,7 +153,7 @@ def _bulk_retrieve_group_values(group_ids: list[int]) -> list[GroupValues]:
                 status=group_values["status"],
                 substatus=group_values["substatus"],
                 first_seen=group_values["first_seen"],
-                num_comments=group_values["num_comments"],
+                num_comments=group_values["num_comments"] or 0,
             )
         )
     return results

diff --git a/src/sentry/issues/endpoints/organization_activity.py b/src/sentry/issues/endpoints/organization_activity.py
@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from datetime import datetime
 
 from rest_framework.request import Request
@@ -70,7 +72,7 @@ def get(
             ).values_list("id", flat=True)
         )
 
-        union_qs = Activity.objects.none()
+        union_qs = Activity.objects.none().values_list("id", flat=True)
         if project_ids:
             projects_qs = [
                 base_qs.filter(project_id=project)[: paginator.max_limit] for project in project_ids

diff --git a/src/sentry/issues/endpoints/organization_searches.py b/src/sentry/issues/endpoints/organization_searches.py
@@ -110,6 +110,7 @@ def post(self, request: Request, organization: Organization) -> Response:
             sort=result["sort"],
             visibility=result["visibility"],
         )
+        assert saved_search.type is not None
         analytics.record(
             "organization_saved_search.created",
             search_type=SearchType(saved_search.type).name,

diff --git a/src/sentry/issues/escalating.py b/src/sentry/issues/escalating.py
@@ -232,7 +232,7 @@ def _query_metrics_with_pagination(
                 metrics_offset,
                 category,
             )
-            projects = Project.objects.filter(id__in=project_ids)
+            projects = list(Project.objects.filter(id__in=project_ids))
             metrics_series_results = get_series(
                 projects=projects,
                 metrics_query=metrics_query,

diff --git a/src/sentry/issues/forecasts.py b/src/sentry/issues/forecasts.py
@@ -3,7 +3,7 @@
 """
 
 import logging
-from collections.abc import Sequence
+from collections.abc import Iterable, Sequence
 from datetime import datetime
 
 from sentry import analytics
@@ -50,7 +50,7 @@ def save_forecast_per_group(
     analytics.record("issue_forecasts.saved", num_groups=len(group_counts.keys()))
 
 
-def generate_and_save_forecasts(groups: Sequence[Group]) -> None:
+def generate_and_save_forecasts(groups: Iterable[Group]) -> None:
     """
     Generates and saves a list of forecasted values for each group.
     `groups`: Sequence of groups to be forecasted

diff --git a/src/sentry/models/group.py b/src/sentry/models/group.py
@@ -5,7 +5,7 @@
 import re
 import warnings
 from collections import defaultdict, namedtuple
-from collections.abc import Mapping, Sequence
+from collections.abc import Iterable, Mapping, Sequence
 from datetime import datetime, timedelta
 from enum import Enum
 from functools import reduce
@@ -417,7 +417,7 @@ def get_groups_by_external_issue(
 
     def update_group_status(
         self,
-        groups: Sequence[Group],
+        groups: Iterable[Group],
         status: int,
         substatus: int | None,
         activity_type: ActivityType,