Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): disable redis span metrics extraction #3600

Merged
merged 4 commits into from
May 16, 2024
Merged

feat(spans): disable redis span metrics extraction #3600

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3ea3108
disable redis span metrics extraction
DominikB2014 May 15, 2024
ad3cfdd
changelog
DominikB2014 May 15, 2024
81675a3
Merge branch 'master' into DominikB2014/dont-ingest-redis
DominikB2014 May 16, 2024
e127756
Merge branch 'master' into DominikB2014/dont-ingest-redis
DominikB2014 May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
- Add support for `event.` in the `Span` `Getter` implementation. ([#3577](https://github.com/getsentry/relay/pull/3577))
- Ensure `chunk_id` and `profiler_id` are UUIDs and sort samples. ([#3588](https://github.com/getsentry/relay/pull/3588))
- Add a calculated measurement based on the AI model and the tokens used. ([#3554](https://github.com/getsentry/relay/pull/3554))

- Disable `db.redis` span metrics extraction. ([#3600](https://github.com/getsentry/relay/pull/3600))

## 24.4.2

Expand Down
8 changes: 7 additions & 1 deletion relay-dynamic-config/src/defaults.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ use crate::metrics::MetricSpec;
use crate::{Feature, MetricExtractionConfig, ProjectConfig, Tag};

/// A list of `span.op` patterns that indicate databases that should be skipped.
const DISABLED_DATABASES: &[&str] = &["*clickhouse*", "*compile*", "*mongodb*", "db.orm"];
const DISABLED_DATABASES: &[&str] = &[
"*clickhouse*",
"*compile*",
"*mongodb*",
"*redis*",
"db.orm",
];

/// A list of `span.op` patterns we want to enable for mobile.
const MOBILE_OPS: &[&str] = &[
Expand Down
Loading
Loading