Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Forward received_at field to Kafka #3561

Merged
merged 24 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ rust-embed = "8.0.0"
schemars = { version = "=0.8.10", features = ["uuid1", "chrono"] }
sentry = "0.32.2"
sentry-core = "0.32.2"
sentry-kafka-schemas = { version = "0.1.79", default-features = false }
sentry-kafka-schemas = { version = "0.1.80", default-features = false }
sentry-release-parser = { version = "1.3.2", default-features = false }
sentry-types = "0.32.2"
sentry_usage_accountant = { version = "0.1.0", default-features = false }
Expand Down
5 changes: 3 additions & 2 deletions relay-server/src/services/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -507,8 +507,6 @@ impl StoreService {
BucketViewValue::Gauge(g) => MetricValue::Gauge(g),
};

// TODO: propagate the `received_at` field upstream.
// https://github.com/getsentry/relay/issues/3515
Ok(MetricKafkaMessage {
org_id: organization_id,
project_id,
Expand All @@ -517,6 +515,7 @@ impl StoreService {
timestamp: view.timestamp(),
tags: view.tags(),
retention_days,
received_at: view.metadata().received_at,
})
}

Expand Down Expand Up @@ -1290,6 +1289,8 @@ struct MetricKafkaMessage<'a> {
timestamp: UnixTimestamp,
tags: &'a BTreeMap<String, String>,
retention_days: u16,
#[serde(default, skip_serializing_if = "Option::is_none")]
iambriccardo marked this conversation as resolved.
Show resolved Hide resolved
received_at: Option<UnixTimestamp>,
}

#[derive(Clone, Debug, Serialize)]
Expand Down
3 changes: 3 additions & 0 deletions tests/integration/asserts/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from .time import time_after, time_within, time_within_delta

__all__ = ["time_after", "time_within", "time_within_delta"]
35 changes: 35 additions & 0 deletions tests/integration/asserts/time.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
from datetime import timedelta, datetime, timezone


class _WithinBounds:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised the formatter doesn't complain about this newline

def __init__(self, lower_bound, upper_bound):
self._lower_bound = lower_bound
self._upper_bound = upper_bound

def __eq__(self, other):
assert isinstance(other, int)
return self._lower_bound <= other <= self._upper_bound

def __str__(self):
return f"{self._lower_bound} <= x <= {self._upper_bound}"


def time_after(lower_bound):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't assert after, but after until now. I think making the upper bound on time_within optional and defaulting to now is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was indeed thinking about a better name.

upper_bound = int(datetime.now(tz=timezone.utc).timestamp())
return time_within(lower_bound, upper_bound)


def time_within(lower_bound, upper_bound):
assert lower_bound <= upper_bound
return _WithinBounds(lower_bound, upper_bound)


def time_within_delta(timestamp, delta=None):
if delta is None:
delta = timedelta(seconds=5)

lower_bound = (datetime.fromtimestamp(timestamp) - delta).timestamp()
upper_bound = (datetime.fromtimestamp(timestamp) + delta).timestamp()

return _WithinBounds(lower_bound, upper_bound)
Loading
Loading