Skip to content

Commit

Permalink
feat(spans): disable redis span metrics extraction (#3600)
Browse files Browse the repository at this point in the history
We originally re-enabled db.redis in order to collect metrics for the
cache module. However, since then we decided that the cache module will
only look at `cache.*` span ops.

Therefore we can stop collecting `db.redis` span metrics.
  • Loading branch information
DominikB2014 authored May 16, 2024
1 parent 25d12f4 commit fb06249
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 247 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
- Restrict usage of OTel endpoint. ([#3597](github.com/getsentry/relay/pull/3597))
- Support new cache span ops in metrics and tag extraction. ([#3598](https://github.com/getsentry/relay/pull/3598))
- Extract additional user fields for spans. ([#3599](https://github.com/getsentry/relay/pull/3599))
- Disable `db.redis` span metrics extraction. ([#3600](https://github.com/getsentry/relay/pull/3600))

## 24.4.2

Expand Down
8 changes: 7 additions & 1 deletion relay-dynamic-config/src/defaults.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ use crate::metrics::MetricSpec;
use crate::{Feature, MetricExtractionConfig, ProjectConfig, Tag};

/// A list of `span.op` patterns that indicate databases that should be skipped.
const DISABLED_DATABASES: &[&str] = &["*clickhouse*", "*compile*", "*mongodb*", "db.orm"];
const DISABLED_DATABASES: &[&str] = &[
"*clickhouse*",
"*compile*",
"*mongodb*",
"*redis*",
"db.orm",
];

/// A list of `span.op` patterns we want to enable for mobile.
const MOBILE_OPS: &[&str] = &[
Expand Down
Loading

0 comments on commit fb06249

Please sign in to comment.