This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
feat(sdk): Add name spaces for metrics rate limits #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Luca Forstner <luca.forstner@gmail.com>
iker-barriocanal
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new rate limit component to quota limits in the
x-sentry-rate-limitsheader that communicates the namespace(s) that a metrics rate limit should apply to. The data category of limits that have this component is alwaysmetric_bucket, in other quotas this component will not be set.SDKs are instructed not to send metrics for a certain namespace if a rate limit for that same namespace is active. The default namespace for metrics (used by DDM) is "custom".
Relay implementation via getsentry/relay#3347
Closes https://github.com/getsentry/team-ingest/issues/313