Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallCommand::processPackage() invoked with 3 parameters, 1-2 required #1682

Merged
merged 1 commit into from
Oct 11, 2017
Merged

InstallCommand::processPackage() invoked with 3 parameters, 1-2 required #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Method Grav\Console\Gpm\InstallCommand::processPackage() invoked with… 
… 3 parameters, 1-2 required.
  • Loading branch information
@villfa
villfa committed Oct 10, 2017
commit 1dd984b5ea95e08d3e35032aae6bd8aafdd28747
6 changes: 3 additions & 3 deletions system/src/Grav/Console/Gpm/InstallCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ protected function serve()
} else {
$is_valid_destination = Installer::isValidDestination($this->destination . DS . $package->install_path);
if ($is_valid_destination || Installer::lastErrorCode() == Installer::NOT_FOUND) {
$this->processPackage($package, true, false);
$this->processPackage($package, false);
} else {
if (Installer::lastErrorCode() == Installer::EXISTS) {

Expand All @@ -205,7 +205,7 @@ protected function serve()

if ($answer) {
$is_update = true;
$this->processPackage($package, true, $is_update);
$this->processPackage($package, $is_update);
} else {
$this->output->writeln("<yellow>Package " . $package_name . " not overwritten</yellow>");
}
Expand Down Expand Up @@ -311,7 +311,7 @@ public function installDependencies($dependencies, $type, $message, $required =
if ($answer) {
foreach ($packages as $dependencyName => $dependencyVersion) {
$package = $this->gpm->findPackage($dependencyName);
$this->processPackage($package, true, ($type == 'update') ? true : false);
$this->processPackage($package, ($type == 'update') ? true : false);
}
$this->output->writeln('');
} else {
Expand Down