Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageMedium#derivatives now works with image filters #1107

Merged
merged 10 commits into from
Oct 23, 2016
Merged

ImageMedium#derivatives now works with image filters #1107

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6a55f7f
ImageMedium->derivatives now works with image filters
fredrikekelund Sep 11, 2016
c2e6292
Modified initialization of image alternatives
fredrikekelund Sep 12, 2016
4d19620
Fully reset image when derivatives method is called
fredrikekelund Sep 12, 2016
7efd55d
Account for risk of original file not existing when generating image …
fredrikekelund Oct 1, 2016
07c9591
Fixed an issue where too many alternatives would be generated
fredrikekelund Oct 5, 2016
25636f5
Merge branch 'develop' into imageDerivativesFilters
fredrikekelund Oct 15, 2016
1d2cc2c
Add an "@1x" alternative when an image lacks a base medium
fredrikekelund Oct 15, 2016
778cc1b
Always make smallest image alternative the base medium
fredrikekelund Oct 16, 2016
91cea78
Set better prettynames for image derivatives
fredrikekelund Oct 16, 2016
baa1d87
Changed image derivatives prettynames to be width based
fredrikekelund Oct 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fully reset image when derivatives method is called 
Otherwise we get some funky results, with the possibility of two
different images being rendered between the full-width srcset
version and the original src version.
  • Loading branch information
@fredrikekelund
fredrikekelund committed Sep 12, 2016
commit 4d1962041b24f5cf87ed0c640f9e55b4aac0a91b
2 changes: 1 addition & 1 deletion system/src/Grav/Common/Page/Medium/ImageMedium.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ public function derivatives($min_width, $max_width, $step = 200) {
// Clear any alternatives that have already been implied by the image's
// filename (eg. ones that had "@2x" or similar appended to their
// filenames)
$this->clearAlternatives();
$this->reset();

while ($width <= $max_width) {
$ratio = $width / $this->get('width');
Expand Down