Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Add a few tests, including for Loader #433

Merged
merged 5 commits into from
Sep 22, 2019
Merged

Add a few tests, including for Loader #433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03c4b1c
Test block_row_index() and block_row_count()
kienstra Sep 18, 2019
a0d252f
Remove needless space between the @param type and the description
kienstra Sep 18, 2019
24ecb6d
Add @covers tags to integration test methods
kienstra Sep 18, 2019
bdb7bfd
Add a unit test for Loader::init(),
kienstra Sep 19, 2019
2c43d58
Use %d instead of %s for integers
kienstra Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove needless space between the @param type and the description 
Also, remove an isset() check
as empty() will handle that case.
  • Loading branch information
@kienstra
kienstra committed Sep 18, 2019
commit a0d252f1c768291242d8b59118277e3e98b35417
2 changes: 1 addition & 1 deletion js/blocks/loader/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* Gets the attributes for a block, based on given fields.
*
* @param {Object} fields The fields to get the attributes from.
* @param {Object} fields The fields to get the attributes from.
lukecarbis marked this conversation as resolved.
Show resolved Hide resolved
* @return {Object} attributes The attributes for the fields.
*/
const getBlockAttributes = ( fields ) => {
Expand Down
2 changes: 1 addition & 1 deletion php/post-types/class-block-post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ public function add_meta_boxes() {
'default'
);

if ( isset( $post->post_name ) && ! empty( $post->post_name ) ) {
if ( ! empty( $post->post_name ) ) {
$locations = block_lab()->get_template_locations( $post->post_name );
$template = block_lab()->locate_template( $locations, '', true );

Expand Down