Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Add a few tests, including for Loader #433

Merged
merged 5 commits into from
Sep 22, 2019
Merged

Add a few tests, including for Loader #433

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03c4b1c
Test block_row_index() and block_row_count()
kienstra Sep 18, 2019
a0d252f
Remove needless space between the @param type and the description
kienstra Sep 18, 2019
24ecb6d
Add @covers tags to integration test methods
kienstra Sep 18, 2019
bdb7bfd
Add a unit test for Loader::init(),
kienstra Sep 19, 2019
2c43d58
Use %d instead of %s for integers
kienstra Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use %d instead of %s for integers 
This is passing it a row number,
so it should not use %s.
  • Loading branch information
@kienstra
kienstra committed Sep 19, 2019
commit 2c43d58da308b3e2f8181d9b4d929576c783e22b
2 changes: 1 addition & 1 deletion tests/php/integration/fixtures/repeater-all-fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
while ( block_rows( $repeater_name ) ) :
block_row( $repeater_name );
printf(
'In row %d, the result of block_row_index() is %s: ',
'In row %d, the result of block_row_index() is %d',
$row_number,
block_row_index()
);
Expand Down
2 changes: 1 addition & 1 deletion tests/php/integration/test-repeater-template-output.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ public function test_repeater_template() {
foreach ( $rows as $row_number => $row ) {
$this->assertContains(
sprintf(
'In row %d, the result of block_row_index() is %s: ',
'In row %d, the result of block_row_index() is %d',
$row_number,
$row_number
),
Expand Down