Merge pull request #145 from chainsawriot/fix144

Fix #144
gesistsa · Jun 14, 2023 · cfc0d25 · cfc0d25
2 parents faa1867 + d28b527
commit cfc0d25
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/R/resolve.R b/R/resolve.R
@@ -228,7 +228,7 @@
                   dep_df$y != "R" & !(dep_df$y %in%
                                       c("datasets", "utils", "grDevices", "graphics", "stats", "methods", "tools",
                                         "grid", "splines", "parallel", "stats4", "tcltk", "MASS", "nnet", "class", "spatial",
-                                        "eda", "lqs", "mle", "modreg", "mva", "stepfun", "ts")),]
+                                        "eda", "lqs", "mle", "modreg", "mva", "stepfun", "ts", "base")),]
     if (nrow(res) == 0) {
         return(NULL)
     }

diff --git a/tests/testdata/dt.RDS b/tests/testdata/dt.RDS
diff --git a/tests/testthat/test_expost_rang.R b/tests/testthat/test_expost_rang.R
@@ -185,3 +185,8 @@ test_that("Super ancient special packages", {
     graph <- readRDS("../testdata/superancientsna.RDS")
     expect_error(.generate_installation_order(graph), NA)
 })
+
+test_that("base as a dependency, issue 144", {
+    graph <- readRDS("../testdata/dt.RDS")
+    expect_error(.generate_installation_order(graph), NA)
+})