Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local time error in satellite diagnostic code #1766

Closed
sdeastham opened this issue Apr 20, 2023 · 4 comments
Closed

Local time error in satellite diagnostic code #1766

sdeastham opened this issue Apr 20, 2023 · 4 comments
Assignees
@yantosca
Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Diagnostics Related to output diagnostic data

Comments

@sdeastham
Copy link
Contributor

geos-chem/GeosCore/diagnostics_mod.F90

Line 686 in 4722f28

LT = Get_LocalTime( I, 1, 1, State_Grid )

The setting of the satellite diagnostics currently assumes that the local time can be calculated using only the first index (i.e. assumes the same longitude for all Y values). However, local time can vary across Y values in GCHP, meaning this code will give incorrect answers.

Contributor: Seb Eastham, MIT
@yantosca
Copy link
Contributor

Thanks for writing @sdeastham. This diagnostic was only ever tested in GEOS-Chem Classic, as the developer was using GEOS-Chem Classic and not GCHP.

We can try to fix this in a 14.2.1 release, as we are wrapping up 14.2.0.

@yantosca yantosca self-assigned this Apr 25, 2023
@yantosca yantosca added category: Bug Something isn't working topic: Diagnostics Related to output diagnostic data labels Apr 25, 2023
@lizziel
Copy link
Contributor

lizziel commented Apr 25, 2023

See also #770. It looks like there was no follow-up about testing in GCHP which must be why the diagnostic is not included in GCHP HISTORY.rc files. It is not actually supported for GCHP yet. This does not appear in any of our documentation because the netcdf satellite diagnostic is not in any of our documentation yet. According to the wiki you still need to use bpch and the netcdf option is not yet listed on ReadTheDocs. We can add that to the todo list for 14.2 as well.

@stale
Copy link

stale bot commented Jun 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Jun 9, 2023
@lizziel lizziel removed the stale No recent activity on this issue label Jun 12, 2023
@yantosca yantosca added the never stale Never label this issue as stale label Jun 28, 2023
@yantosca
Copy link
Contributor

Closing out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yantosca yantosca

Labels
category: Bug Something isn't working never stale Never label this issue as stale topic: Diagnostics Related to output diagnostic data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lizziel @yantosca @sdeastham