Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support geodesic area and perimeter calculations from geographlib-rs #988

Merged
merged 11 commits into from
Mar 6, 2023
Merged

Adding support geodesic area and perimeter calculations from geographlib-rs #988

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6af9e4a
Adding support geodesic area and perimeter calculations from geograph…
phayes Feb 27, 2023
38cd43a
Updating changes to report new GeodesicArea trait
phayes Feb 27, 2023
cd74de1
Adding more asserts to tests
phayes Feb 27, 2023
e6eea06
Update geo/src/algorithm/geodesic_area.rs
phayes Feb 28, 2023
41c6c21
Bumping geographiclib version
phayes Mar 2, 2023
94ab281
Fixing merge conflict
phayes Mar 2, 2023
aea403e
Adding more tests, adjusting epsilons for test asserts
phayes Mar 3, 2023
52162d0
Adding another test for very large polygons
phayes Mar 3, 2023
adaaa7f
Cargo fmt
phayes Mar 3, 2023
03e23dd
Update geo/src/algorithm/geodesic_area.rs
phayes Mar 5, 2023
0d15e56
Removing unused generic param
phayes Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding more asserts to tests
  • Loading branch information
@phayes
phayes committed Feb 27, 2023
commit cd74de158883fa82c793882a1b5f625344acf92f
25 changes: 25 additions & 0 deletions geo/src/algorithm/geodesic_area.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,9 @@ mod test {
(x: 125., y: -15.),
];
assert_relative_eq!(-7786102826806.07, polygon.geodesic_area_signed());
phayes marked this conversation as resolved.
Show resolved Hide resolved

let geoid = geographiclib_rs::Geodesic::wgs84();
assert_relative_eq!(geoid.area() -7786102826806.07, polygon.geodesic_area_unsigned());
}

#[test]
Expand All @@ -383,6 +386,7 @@ mod test {
(x: 125., y: -15.),
];
assert_relative_eq!(7786102826806.07, polygon.geodesic_area_signed());
assert_relative_eq!(7786102826806.07, polygon.geodesic_area_unsigned());
}

#[test]
Expand Down Expand Up @@ -415,6 +419,17 @@ mod test {

assert_relative_eq!(1203317999173.7063, poly.geodesic_area_signed());
assert_relative_eq!(1203317999173.7063, poly.geodesic_area_unsigned());
assert_relative_eq!(5307742.446635911, poly.geodesic_perimeter());

let (perimeter, area) = poly.geodesic_perimeter_area_signed();

assert_relative_eq!(5307742.446635911, perimeter);
assert_relative_eq!(1203317999173.7063, area);

let (perimeter, area) = poly.geodesic_perimeter_area_unsigned();

assert_relative_eq!(5307742.446635911, perimeter);
assert_relative_eq!(1203317999173.7063, area);
}

#[test]
Expand Down Expand Up @@ -474,6 +489,16 @@ mod test {
],
];
assert_relative_eq!(18462065880.09138, diamond.geodesic_area_unsigned());
assert_relative_eq!(18462065880.09138, diamond.geodesic_area_signed());
assert_relative_eq!(941333.0085011568, diamond.geodesic_perimeter());

let (perimeter, area) = diamond.geodesic_perimeter_area_signed();
assert_relative_eq!(941333.0085011568, perimeter);
assert_relative_eq!(18462065880.09138, area);

let (perimeter, area) = diamond.geodesic_perimeter_area_unsigned();
assert_relative_eq!(941333.0085011568, perimeter);
assert_relative_eq!(18462065880.09138, area);
}

}