Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#553 Clippy: Don't call into_iter on types that support iter #554

Merged
merged 1 commit into from
Dec 3, 2020
Merged

#553 Clippy: Don't call into_iter on types that support iter #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
#553 Clippy: Don't call into_iter on types that support iter
  • Loading branch information
@martinfrances107
martinfrances107 committed Dec 3, 2020
commit ba2f57abc2b2aac10bb6f93ad3c9e661f32fa2c0
2 changes: 1 addition & 1 deletion geo-types/src/multi_line_string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl<'a, T: CoordinateType> IntoIterator for &'a MultiLineString<T> {
type IntoIter = ::std::slice::Iter<'a, LineString<T>>;

fn into_iter(self) -> Self::IntoIter {
(&self.0).into_iter()
(&self.0).iter()
}
}

Expand Down
2 changes: 1 addition & 1 deletion geo-types/src/multi_point.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ impl<'a, T: CoordinateType> IntoIterator for &'a MultiPoint<T> {
type IntoIter = ::std::slice::Iter<'a, Point<T>>;

fn into_iter(self) -> Self::IntoIter {
(&self.0).into_iter()
(&self.0).iter()
}
}

Expand Down
2 changes: 1 addition & 1 deletion geo-types/src/multi_polygon.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ impl<'a, T: CoordinateType> IntoIterator for &'a MultiPolygon<T> {
type IntoIter = ::std::slice::Iter<'a, Polygon<T>>;

fn into_iter(self) -> Self::IntoIter {
(&self.0).into_iter()
(&self.0).iter()
}
}

Expand Down
2 changes: 1 addition & 1 deletion geo/src/algorithm/simplify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ where
}
compute_rdp(
&points
.into_iter()
.iter()
.enumerate()
.map(|(idx, point)| RdpIndex {
index: idx,
Expand Down