Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geode is redefining Cocoa's "CommentType", and messing up MacOS!!! #1198

Open
1 task done
FireDasher opened this issue Dec 21, 2024 · 1 comment
Open
1 task done

Geode is redefining Cocoa's "CommentType", and messing up MacOS!!! #1198

FireDasher opened this issue Dec 21, 2024 · 1 comment
Labels
bug Something isn't working unverified

Comments

@FireDasher
Copy link

FireDasher commented Dec 21, 2024 •
edited
Loading

Geode Issue

  • I confirm that this bug is NOT related to a mod but directly to Geode Loader itself.

Platform

MacOS

Geode Version

4.1.1

Steps to Reproduce

compile custom key binds for macOS

What is happening

Some stupid Script.h thing is getting messed up because Geode is redefining CommentType but Script.h uses Cocoa's CommentType, which Geode deleted and replaced with GD's CommentType. And Script.h is an internal Mac thing so I can't modify it.
@FireDasher FireDasher added bug Something isn't working unverified labels Dec 21, 2024
@qimiko
Copy link
Contributor

qimiko commented Dec 22, 2024

the easy solution is just to

#define CommentType CommentTypeDummy

// your macos specific includes here

#undef CommentType

i think there's been attempts to avoid it but it basically just does the same thing as this (but this actually works and those attempts... don't)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working unverified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qimiko @FireDasher