Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support RubyGems 2.3.x and earlier #428

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Drop support RubyGems 2.3.x and earlier #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Drop support RubyGems 2.3.x and earlier 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
  • Loading branch information
@tnir
tnir committed Jun 28, 2022
commit 79efda5c73f3dbabaaf90d6346937403c84ce6df
27 changes: 13 additions & 14 deletions .github/workflows/ruby.yml
View file
Original file line number Diff line number Diff line change
@@ -23,21 +23,24 @@ jobs:
gem-version: 2.7.11
- ruby-version: 2.5.9
gem-version: 2.7.11
# RubyGems 1.8 should be tested
# Test with RubyGems 2.4.8 as it is specified in gemspec
- ruby-version: 2.2.10
gem-version: 1.8.25
gem-version: 2.4.8
continue-on-error: true
- ruby-version: 2.3.8
gem-version: 1.8.25
gem-version: 2.4.8
continue-on-error: true
- ruby-version: 2.4.10
gem-version: 1.8.25
gem-version: 2.4.8
continue-on-error: true
- ruby-version: 2.5.9
gem-version: 1.8.25
gem-version: 2.4.8
continue-on-error: true
- ruby-version: 2.6.10
gem-version: 1.8.25
gem-version: 2.4.8
continue-on-error: true
- ruby-version: 2.7.6
gem-version: 2.4.8
continue-on-error: true

steps:
@@ -53,15 +56,11 @@ jobs:
run: |
gem update --system $gemver
gem --version
# TODO: remove this step when RubyGems 1.8 support is dropped
# RubyGems 1.8 does not support Gem::Specification#metadata=, so removing the line
# https://github.com/rubygems/rubygems/commit/be483b99d8a53bce3e6faf9e6f3c3a5df452974e
# or https://github.com/rubygems/rubygems/pull/38
# Use Bundler 1.17 when using RubyGems 1.8
- name: Tweak gemspec fixtures for testing and use Bundler 1.x
if: startsWith(matrix.gem-version, '1.')
# TODO: remove this step when RubyGems 2.4 support is dropped
# Use Bundler 1.17 when using RubyGems 1.x and 2.0-2.4
- name: Install Bundler 1.x for RubyGems 2.4
if: startsWith(matrix.gem-version, '2.4')
run: |
sed -i -e "/metadata/d" geminabox.gemspec
gem uninstall bundler
gem install bundler --version "< 2"
sed -i -e "/^BUNDLED WITH/ {n; s/.*/ 1.17.3/} " Gemfile.lock
2 changes: 1 addition & 1 deletion geminabox.gemspec
View file
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
s.metadata = { "source_code_uri" => "https://github.com/geminabox/geminabox" }

s.required_ruby_version = ">= 2.2.0"
s.required_rubygems_version = ">= 1.8.25"
s.required_rubygems_version = ">= 2.4.0"

s.extra_rdoc_files = %w[README.md]
s.rdoc_options = %w[--main README.md]