Support locales in ping output #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loosen the regex to search for a time value, to support non-english output of the ping command. Since the output is generic in all languages we dont need to look for a specific english term. Refs geerlingguy#5 Refs geerlingguy#49
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
|
Just a sidenote: this PR was marked as |
|
This issue is no longer marked for closure. |
|
Added the label. I will try to get this merged after I do a little extra repo maintenance. Thanks for your patience! |
|
@geerlingguy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen the regex to search for a time value, to support non-english output of the ping command.
Since the output is generic in all languages we dont need to look for a specific english term.
This avoids introducing translations or keyword flags and so on.
Tested in German and English. I looked for other languages as well, almost all languages with latin characters use "ms" as abbreviation for milliseconds.
Issue #49 shows that this works in Chinese as well.
Unit Test were red before on my machine, green now. 🎉
Refs #5 Refs #49
btw: Thanks for this package :)