fix: remove effective scroll action

gdsttian · Sep 7, 2024 · 1c6786b · 1c6786b
1 parent a69b241
commit 1c6786b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/src/context/scroll-context/scroll-context.tsx b/src/context/scroll-context/scroll-context.tsx
@@ -6,11 +6,9 @@ export type ScrollActionType = 'pan' | 'zoom';
 export interface ScrollContext {
     scrollAction: ScrollActionType;
     setScrollAction: (action: ScrollActionType) => void;
-    effectiveScrollAction: ScrollActionType;
 }
 
 export const ScrollContext = createContext<ScrollContext>({
     scrollAction: 'pan',
     setScrollAction: emptyFn,
-    effectiveScrollAction: 'pan',
 });
diff --git a/src/context/scroll-context/scroll-provider.tsx b/src/context/scroll-context/scroll-provider.tsx
@@ -11,19 +11,12 @@ export const ScrollProvider: React.FC<React.PropsWithChildren> = ({
         return savedAction || 'pan';
     });
 
-    const [effectiveScrollAction, setEffectiveScrollAction] =
-        useState<ScrollActionType>('pan');
-
     useEffect(() => {
-        console.log('coucou');
         localStorage.setItem('scrollAction', scrollAction);
-        setEffectiveScrollAction(scrollAction);
     }, [scrollAction]);
 
     return (
-        <ScrollContext.Provider
-            value={{ scrollAction, setScrollAction, effectiveScrollAction }}
-        >
+        <ScrollContext.Provider value={{ scrollAction, setScrollAction }}>
             {children}
         </ScrollContext.Provider>
     );

diff --git a/src/pages/editor-page/canvas/canvas.tsx b/src/pages/editor-page/canvas/canvas.tsx
@@ -65,7 +65,7 @@ export const Canvas: React.FC<CanvasProps> = ({ initialTables }) => {
     } = useChartDB();
     const { showSidePanel } = useLayout();
     const { effectiveTheme } = useTheme();
-    const { effectiveScrollAction } = useScrollAction();
+    const { scrollAction } = useScrollAction();
     const { isMd: isDesktop } = useBreakpoint('md');
     const nodeTypes = useMemo(() => ({ table: TableNode }), []);
     const edgeTypes = useMemo(() => ({ 'table-edge': TableEdge }), []);
@@ -287,7 +287,7 @@ export const Canvas: React.FC<CanvasProps> = ({ initialTables }) => {
                     animated: false,
                     type: 'table-edge',
                 }}
-                panOnScroll={effectiveScrollAction === 'pan'}
+                panOnScroll={scrollAction === 'pan'}
             >
                 {isLoadingDOM ? (
                     <Controls