Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel updates for Harmonic #397

Merged
merged 26 commits into from
Apr 5, 2024
Merged

Bazel updates for Harmonic #397

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4795e34
Harmonic bazel
mjcarroll Oct 11, 2023
cf54236
Fix RE and install path
mjcarroll Feb 6, 2024
4fc843f
Fix up generate script
mjcarroll Feb 6, 2024
f7db1e1
Minimize diff
mjcarroll Feb 6, 2024
8881d33
Fix arg
mjcarroll Feb 6, 2024
554b57c
Revert all changes to gz_msgs_generate
mjcarroll Feb 6, 2024
35d48cd
Clean up harmonic implementation
mjcarroll Mar 4, 2024
6338d74
Add a "lite" factory variant
mjcarroll Mar 4, 2024
5138cc5
Add lint support
mjcarroll Mar 4, 2024
4e73795
Generate command line files
mjcarroll Mar 8, 2024
b4ac4da
Allow dynamic factory to load from descriptor files
mjcarroll Mar 8, 2024
4a840f8
Lint
mjcarroll Mar 8, 2024
155304a
Remove dead code
mjcarroll Mar 8, 2024
8e1d0db
Add iostream header
mjcarroll Mar 8, 2024
f02ed90
Change data deps
mjcarroll Mar 8, 2024
0ebc366
Lint
mjcarroll Mar 8, 2024
8d03c23
Needs .string() on Windows
mjcarroll Mar 8, 2024
4ed4226
add docs
mjcarroll Mar 8, 2024
e55e4e3
IWYU
mjcarroll Mar 8, 2024
a6fab0c
Move generated file location
mjcarroll Mar 8, 2024
3df1f83
Merge branch 'mjcarroll/port/9_to_10' into mjcarroll/bazel_harmonic
mjcarroll Mar 11, 2024
dbb7688
Add descriptors test
mjcarroll Mar 11, 2024
42ff5a2
Merge branch 'gz-msgs10' into mjcarroll/bazel_harmonic
mjcarroll Mar 11, 2024
317d704
Differentiate message names
mjcarroll Apr 1, 2024
1c36fed
Address reviewer comments
mjcarroll Apr 3, 2024
bb61343
Merge branch 'gz-msgs10' into mjcarroll/bazel_harmonic
mjcarroll Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'mjcarroll/port/9_to_10' into mjcarroll/bazel_harmonic 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
  • Loading branch information
@mjcarroll
mjcarroll committed Mar 11, 2024
commit 3df1f8338f6b3734f6a8cf5ab6312423093f962d
4 changes: 2 additions & 2 deletions core/src/DynamicFactory.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,9 @@ void DynamicFactory::LoadDescriptors(const std::string &_paths)

auto loadDescFile = [this](const std::string &descFile)
{
// Ignore files without the correct extensions.
// Ignore files without the .desc extension.
if (descFile.rfind(".desc") == std::string::npos &&
descFile.rfind(".gz_desc") == std::string::npos &&
descFile.rfind(".proto") == std::string::npos &&
descFile.rfind(".proto.bin") == std::string::npos)
return;
Expand Down Expand Up @@ -132,7 +133,6 @@ void DynamicFactory::LoadDescriptors(const std::string &_paths)
}
};


for (const std::string &descDir : descDirs)
{
if (!std::filesystem::is_directory(descDir))
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.