Address reviewer comments

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
gazebosim · mjcarroll · Apr 5, 2024 · Oct 11, 2023 · Feb 6, 2024 · Feb 6, 2024
commit 1c36fed06a92913b475c5f8afc2e6bb93474568d
@@ -122,6 +122,10 @@ cc_library(
         "core/src/RegisterMsgs.cc",
         "core/src/impl/InstallationDirectories.cc",
     ],
+    copts = [
+      "-Wno-duplicate-decl-specifier",
+      "-fexceptions",
+    ],
     hdrs = public_headers,
     includes = [
         "core/include",

@@ -26,7 +26,7 @@ namespace protobuf {
 namespace compiler {
 namespace cpp {
 /// \cond
-/// \brief Google protobuf message generator for igntion::msgs
+/// \brief Google protobuf message generator for gz::msgs
 class Generator : public CodeGenerator
 {
   /// \brief Constructor
@@ -47,7 +47,6 @@ class Generator : public CodeGenerator
               OutputDirectory *_generatorContext,
               std::string *_error) const;
 
-  // private: GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(Generator);
 };
 /// \endcond
 }

@@ -23,5 +23,5 @@ namespace gz::msgs
 {
 inline namespace GZ_MSGS_VERSION_NAMESPACE {
 std::string getInstallPrefix() { return {};}
-}  // namespcae
+}  // namespace
 }  // namespace gz::msgs