Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a message that allows loading environments via a topic #320

Merged
merged 14 commits into from
Aug 4, 2023
+184 −0
Merged

Adds a message that allows loading environments via a topic #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f4b43a5
Adds a message that allows loading environments via a topic
arjo129 Dec 20, 2022
56b157a
style
arjo129 Dec 20, 2022
303df10
Address PR feedback.
arjo129 Dec 20, 2022
2475c08
Style
arjo129 Jan 5, 2023
9b39a6d
coverage
arjo129 Jan 5, 2023
cc4ce08
style
arjo129 Jan 25, 2023
940b2db
Merge remote-tracking branch 'origin/gz-msgs9' into arjo/feat/environ…
arjo129 Feb 16, 2023
4c60886
Bump copyright
arjo129 Mar 1, 2023
e4129c9
Merge branch 'gz-msgs9' into arjo/feat/environment_data_messages
arjo129 Apr 13, 2023
8c0e400
Address PR feedback
arjo129 May 9, 2023
c1766cf
Coverage
arjo129 May 10, 2023
101a723
Get rid of compiler
arjo129 May 10, 2023
bc90bd5
Style
arjo129 May 10, 2023
97531a0
Merge branch 'gz-msgs9' into arjo/feat/environment_data_messages
mjcarroll Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address PR feedback 
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
  • Loading branch information
@arjo129
arjo129 committed May 9, 2023
commit 8c0e400c8517c2a79c9bc849e3ab07163c643603
2 changes: 1 addition & 1 deletion include/gz/msgs/Utility.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ namespace gz

/// \brief Convert a gz::math::SphericalCoordinates::CoordinateType
/// to a msgs::SphericalCoordinatesType
/// \param[in] _coord The spherical coordinates to convert
/// \param[in] _coord The spherical coordinates type to convert
/// \return A gz::msgs::SphericalCoordinatesType object
GZ_MSGS_VISIBLE
msgs::SphericalCoordinatesType ConvertCoord(
Expand Down
5 changes: 4 additions & 1 deletion src/Utility.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,11 @@ namespace gz
return math::SphericalCoordinates::CoordinateType::SPHERICAL;
case msgs::SphericalCoordinatesType::LOCAL:
return math::SphericalCoordinates::CoordinateType::LOCAL;
default:
case msgs::SphericalCoordinatesType::LOCAL2:
return math::SphericalCoordinates::CoordinateType::LOCAL2;
arjo129 marked this conversation as resolved.
Show resolved Hide resolved
}
std::cerr << "Invalid coordinate type passed" << std::endl;
return math::SphericalCoordinates::CoordinateType::LOCAL2;
}

/////////////////////////////////////////////
Expand Down Expand Up @@ -385,6 +387,7 @@ namespace gz
default:
return msgs::SphericalCoordinatesType::LOCAL2;
Copy link
Collaborator

@caguero caguero Dec 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block returns a warning as we don't return anything if none of the previous conditions are met.

}
std::cerr << "Invalid coordinate type passed" << std::endl;
}

/////////////////////////////////////////////
Expand Down