Backport 2 ⬅️ 5 - Add standalone executables (#121) #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add standalone executables Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback and more tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Add one more test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@Crola1702 could you rebase and force push with lease with a signed commit? That way the DCO bot won't complain. |
azeey
requested changes
Apr 25, 2024
| #-------------------------------------- | ||
| # Find ignition-utils | ||
| ign_find_package(ignition-utils1 REQUIRED COMPONENTS cli) | ||
| set(IGN_UTILS_VER ${ignition-utils1_VERSION_MAJOR}) |
There was a problem hiding this comment.
We wouldn't want to add a new dependency to a stable branch. If this is needed to fix the tests, let's just disable them. I'm doing so in #255, so maybe that could be backported instead.
There was a problem hiding this comment.
no, it's not for the tests, it's using the cli component for the standalone executables:
I'll see if we can backport some of the cmake changes without switching to a standalone executable
There was a problem hiding this comment.
@scpeters were you able to take a look to that? let us know if we can help you on that one
azeey
added
beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #208
Summary
Suggested by #208 (comment) to check if this fixes the problem
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.