Fixing build failures

gavinhughpalmer · Jan 19, 2022 · 30183fe · 30183fe
1 parent 67a3adf
commit 30183fe
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 17 deletions.
diff --git a/force-app/main/utilities/schema/classes/SchemaFacade.cls b/force-app/main/utilities/schema/classes/SchemaFacade.cls
@@ -84,6 +84,7 @@ public without sharing class SchemaFacade {
      * @description retrieves the field describe for the object and field name provided,
      * it will traverse the SObjectField's so you don't have to
      */
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     public DescribeFieldResult getFieldDescribe(String objectApiName, String fieldApiName) {
         objectApiName = objectApiName.toLowerCase();
         fieldApiName = fieldApiName.toLowerCase();

diff --git a/force-app/main/utilities/schema/classes/StateCountryCodeMapper.cls b/force-app/main/utilities/schema/classes/StateCountryCodeMapper.cls
@@ -7,9 +7,11 @@
  *
  **/
 public with sharing class StateCountryCodeMapper extends Triggerable {
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private final PicklistValueSet stateValueSet = new PicklistValueSet(
         Account.BillingStateCode.getDescribe()
     );
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private final PicklistValueSet countryValueSet = new PicklistValueSet(
         Account.BillingCountryCode.getDescribe()
     );

diff --git a/force-app/main/utilities/string-utilities/classes/QueryBuilder.cls b/force-app/main/utilities/string-utilities/classes/QueryBuilder.cls
@@ -12,6 +12,7 @@ public virtual class QueryBuilder {
     protected final SchemaFacade schema = SchemaFacade.getInstance();
     protected final DescribeSObjectResult objectDescribe;
 
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     protected QueryBuilder(String objectName) {
         validateObjectName(objectName);
         this.objectName = objectName;

diff --git a/force-app/tests/test-factories/classes/TestFactory.cls b/force-app/tests/test-factories/classes/TestFactory.cls
diff --git a/force-app/tests/test-factories/classes/TestFactory.cls-meta.xml b/force-app/tests/test-factories/classes/TestFactory.cls-meta.xml
diff --git a/force-app/tests/utilities/dml-mock/classes/IdGeneratorMock.cls b/force-app/tests/utilities/dml-mock/classes/IdGeneratorMock.cls
@@ -20,7 +20,7 @@ public with sharing class IdGeneratorMock {
         String prefix;
 
         try {
-            prefix = sObjectType.getDescribe().getKeyPrefix();
+            prefix = sObjectType.getDescribe(SObjectDescribeOptions.DEFERRED).getKeyPrefix();
         } catch (Exception exceptionToHandle) {
             throw new IdGeneratorMockException('Cannot resolve prefix for SObject,' + sObjectType);
         }

diff --git a/force-app/tests/utilities/schema/classes/SObjectRecordTypesTest.cls b/force-app/tests/utilities/schema/classes/SObjectRecordTypesTest.cls
@@ -40,7 +40,7 @@ private class SObjectRecordTypesTest {
     private static void getRecordTypeIdTest() {
         SObjectRecordTypes opportunityRecordTypes = new SObjectRecordTypes('Opportunity');
         final String recordTypeName = (new List<String>(
-            Account.SObjectType.getDescribe().getRecordTypeInfosByDeveloperName().keySet()
+            Account.SObjectType.getDescribe(SObjectDescribeOptions.DEFERRED).getRecordTypeInfosByDeveloperName().keySet()
         ))[0];
         System.assertNotEquals(
             null,

diff --git a/force-app/tests/utilities/schema/classes/SObjectWrapperTest.cls b/force-app/tests/utilities/schema/classes/SObjectWrapperTest.cls
@@ -73,6 +73,7 @@ private class SObjectWrapperTest {
     }
 
     @isTest
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private static void describeTestObjectField() {
         Account testAccount = new Account();
         SObjectWrapper wrappedTestAccount = new SObjectWrapper(testAccount);
@@ -84,6 +85,7 @@ private class SObjectWrapperTest {
     }
 
     @isTest
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private static void describeTestRelatedObjectField() {
         Contact testContact = new Contact();
         SObjectWrapper wrappedTestContact = new SObjectWrapper(testContact);
@@ -95,6 +97,7 @@ private class SObjectWrapperTest {
     }
 
     @isTest
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private static void describeRelatedObjectFieldRecursive() {
         Contact testContact = new Contact();
         SObjectWrapper wrappedTestContact = new SObjectWrapper(testContact);

diff --git a/force-app/tests/utilities/schema/classes/SchemaFacadeTest.cls b/force-app/tests/utilities/schema/classes/SchemaFacadeTest.cls
@@ -40,13 +40,14 @@ private class SchemaFacadeTest {
     @IsTest
     private static void getDescribe() {
         System.assertEquals(
-            Account.SObjectType.getDescribe(),
+            Account.SObjectType.getDescribe(SObjectDescribeOptions.DEFERRED),
             SchemaFacade.getInstance().getDescribe('Account'),
             'The dynamic describe call should return the account describe object'
         );
     }
 
     @IsTest
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private static void getFieldDescribe() {
         System.assertEquals(
             Account.Name.getDescribe(),
@@ -56,6 +57,7 @@ private class SchemaFacadeTest {
     }
 
     @IsTest
+    @SuppressWarnings('PMD.EagerlyLoadedDescribeSObjectResult')
     private static void getDescribeException() {
         final String invalidObjectName = 'Invalid Object';
         try {