Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GH-36): investigate using the stream #37

Merged
merged 6 commits into from
Jun 18, 2024
Merged

feat(GH-36): investigate using the stream #37

merged 6 commits into from
Jun 18, 2024

Conversation

gavanlamb
Copy link
Owner

feat(GH-36): investigate using the stream

Pipeline

Description

  • Set the execution to be silent

Testing

  • Tested changes in sample application
  • Add unit tests and maintained a branch coverage of 100%
  • Addressed mutation testing results

@gavanlamb gavanlamb linked an issue Jun 18, 2024 that may be closed by this pull request
Investigate using the stream #36
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Test Results

 1 files  ±0  12 suites  ±0   35s ⏱️ -1s
96 tests ±0  96 ✅ ±0  0 💤 ±0  0 ❌ ±0 
99 runs  ±0  99 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0e521c4. ± Comparison against base commit eab5743.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
DotnetOutdatedCommandProblem ‑ should create an instance of DotnetOutdatedCommandProblem with the correct properties
DotnetOutdatedCommandProblem ‑ should have a stack trace
listOutdatedPackages ‑ should throw an error exit code is not 0
listOutdatedPackages ‑ should throw an error when there are problems

DotnetOutdatedCommandProblemError ‑ should create an instance of DotnetOutdatedCommandProblemError with the correct properties
DotnetOutdatedCommandProblemError ‑ should have a stack trace
listOutdatedPackages ‑ should throw an DotnetOutdatedCommandProblemError when there are problems
listOutdatedPackages ‑ should throw an error when exit code is not 0

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

@@ Code coverage @@
+ 99% total lines covered
360 lines analyzed, 359 lines covered
! 100% fresh lines covered
12 lines analyzed, 12 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 58 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
@actions/core 1.10.1 MIT
@actions/exec 1.1.1 MIT
@actions/github 6.0.0 MIT
@actions/http-client 2.2.0 MIT
@actions/io 1.1.3 MIT
@fastify/busboy 2.1.1 MIT
@octokit/app 15.1.0 MIT
@octokit/auth-app 7.1.0 MIT
@octokit/auth-oauth-app 8.1.1 MIT
@octokit/auth-oauth-user 5.1.1 MIT
@octokit/auth-token 4.0.0 MIT
@octokit/auth-token 5.1.1 MIT
@octokit/auth-unauthenticated 6.1.0 MIT
@octokit/core 5.2.0 MIT
@octokit/core 6.1.2 MIT
@octokit/endpoint 10.1.1 MIT
@octokit/graphql 7.1.0 MIT
@octokit/graphql 8.1.1 MIT
@octokit/oauth-app 7.1.2 MIT
@octokit/openapi-types 20.0.0 MIT
@octokit/openapi-webhooks-types 8.2.1 MIT
@octokit/plugin-paginate-graphql 5.2.2 MIT
@octokit/plugin-paginate-rest 11.3.0 MIT
@octokit/plugin-paginate-rest 9.2.1 MIT
@octokit/plugin-rest-endpoint-methods 10.4.1 MIT
@octokit/plugin-rest-endpoint-methods 13.2.1 MIT
@octokit/plugin-retry 7.1.1 MIT
@octokit/plugin-throttling 9.3.0 MIT
@octokit/request-error 5.1.0 MIT
@octokit/request-error 6.1.1 MIT
@octokit/request 8.4.0 MIT
@octokit/request 9.1.1 MIT
@octokit/types 12.6.0 MIT
@octokit/types 13.5.0 MIT
@octokit/webhooks-methods 5.1.0 MIT
@octokit/webhooks 13.2.7 MIT
aggregate-error 5.0.0 MIT
before-after-hook 2.2.3 Apache-2.0
before-after-hook 3.0.2 Apache-2.0
bottleneck 2.19.5 MIT
clean-stack 5.2.0 MIT
deprecation 2.3.1 ISC
escape-string-regexp 5.0.0 MIT
indent-string 5.0.0 MIT
lru-cache 10.2.2 ISC
lru-cache 6.0.0 ISC
octokit 4.0.2 MIT
once 1.4.0 ISC
semver-diff 4.0.0 MIT
semver 7.6.0 ISC
tunnel 0.0.6 MIT
undici 5.28.4 MIT
universal-github-app-jwt 2.2.0 MIT
universal-user-agent 6.0.1 ISC
universal-user-agent 7.0.2 ISC
uuid 8.3.2 MIT
wrappy 1.0.2 ISC
yallist 4.0.0 ISC
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions GitHub Actions
Copy link

.Net Outdated

All packages are up-to-date with the latest versions

@gavanlamb gavanlamb merged commit 54d3072 into main Jun 18, 2024
6 checks passed
@gavanlamb gavanlamb deleted the feature/GH-36-investigate-using-the-stream branch June 18, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate using the stream
1 participant
@gavanlamb