settings: add v2DataEngineLogFlags and v2DataEngineLogLevel

Longhorn 7939 Signed-off-by: Derek Su <derek.su@suse.com>
gauravngandhi · Mar 21, 2024 · 9075f02 · 9075f02
1 parent 257a672
commit 9075f02
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/chart/README.md b/chart/README.md
@@ -322,6 +322,8 @@ During installation, you can either allow Longhorn to use the default system set
 | defaultSettings.v2DataEngine | Setting that allows you to enable the V2 Data Engine, which is based on the Storage Performance Development Kit (SPDK). The V2 Data Engine is a preview feature and should not be used in production environments. |
 | defaultSettings.v2DataEngineGuaranteedInstanceManagerCPU | Number of millicpus on each node to be reserved for each Instance Manager pod when the V2 Data Engine is enabled. The default value is "1250". |
 | defaultSettings.v2DataEngineHugepageLimit | Setting that allows you to configure maximum huge page size (in MiB) for the V2 Data Engine. |
+| defaultSettings.v2DataEngineLogLevel | This allows users to configure the log level if SPDK target daemon (spdk_tgt) of V2 Data Engine. |
+| defaultSettings.v2DataEngineLogFlags | This allows users to configure the log flags if SPDK target daemon (spdk_tgt) of V2 Data Engine. |
 
 ---
 Please see [link](https://github.com/longhorn/longhorn) for more information.
diff --git a/chart/questions.yaml b/chart/questions.yaml
@@ -695,6 +695,25 @@ questions:
   group: "Longhorn V2 Data Engine (Preview Feature) Settings"
   type: int
   default: "2048"
+- variable: defaultSettings.v2DataEngineLogLevel
+  label: V2 Data Engine
+  description: "This allows users to configure the log level if SPDK target daemon (spdk_tgt) of V2 Data Engine."
+  group: "Longhorn V2 Data Engine (Preview Feature) Settings"
+  type: enum
+  options:
+  - "Disabled"
+  - "Error"
+  - "Warn"
+  - "Notice"
+  - "Info"
+  - "Debug"
+  default: "Notice"
+- variable: defaultSettings.v2DataEngineLogFlags
+  label: V2 Data Engine
+  description: "This allows users to configure the log flags if SPDK target daemon (spdk_tgt) of V2 Data Engine."
+  group: "Longhorn V2 Data Engine (Preview Feature) Settings"
+  type: string
+  default:
 - variable: defaultSettings.offlineReplicaRebuilding
   label: Offline Replica Rebuilding
   description: "Setting that allows rebuilding of offline replicas for volumes using the V2 Data Engine."

diff --git a/chart/templates/default-setting.yaml b/chart/templates/default-setting.yaml
@@ -226,4 +226,10 @@ data:
     {{- end }}
     {{- if not (kindIs "invalid" .Values.defaultSettings.snapshotMaxCount) }}
     snapshot-max-count: {{ .Values.defaultSettings.snapshotMaxCount }}
+    {{- end }}
+    {{- if not (kindIs "invalid" .Values.defaultSettings.v2DataEngineLogLevel) }}
+    v2-data-engine-log-level: {{ .Values.defaultSettings.v2DataEngineLogLevel }}
+    {{- end }}
+    {{- if not (kindIs "invalid" .Values.defaultSettings.v2DataEngineLogFlags) }}
+    v2-data-engine-log-flags: {{ .Values.defaultSettings.v2DataEngineLogFlags }}
     {{- end }}
diff --git a/chart/values.yaml b/chart/values.yaml
@@ -321,6 +321,10 @@ defaultSettings:
   disableSnapshotPurge: ~
   # -- Maximum snapshot count for a volume. The value should be between 2 to 250
   snapshotMaxCount: ~
+  # -- This allows users to configure the log level if SPDK target daemon (spdk_tgt) of V2 Data Engine.
+  v2DataEngineLogLevel: ~
+  # This allows users to configure the log flags if SPDK target daemon (spdk_tgt) of V2 Data Engine.
+  v2DataEngineLogFlags: ~
 
 privateRegistry:
   # -- Setting that allows you to create a private registry secret.