Clarify notes about the port for Windows installation #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies if I caused confusion around the port behaviour. Running the installer as you described with PowerShell would have the installer pick up the variable and use the port for UI shortcuts, but Backrest would still listen on the default port. Also, using :<port> instead of 127.0.0.1:<port> would cause Backrest to listen on all interfaces, thus exposing it to outside access. The correct way to define a user variable persistently is described in this commit. I also made changes to the installer, including the language around the port. If Backrest supported port definition through a command-line switch (like --port=<port>), then I could add an option to the installer to take user input and create the startup shortcut with the switch. The switch would have to be available for the backrest-windows-tray.exe since that's what starts the software. Not saying this is needed, just explaining what would have to be done to avoid the environment variable steps I described. Unfortunately, Windows doesn't support passing session variables through shortcuts, unless using cmd wrapper script.
|
Thanks for catching this! And very much appreciate the expanded instructions, that's non-trivial and will be very useful to anyone installing on multiple user accounts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies if I caused confusion around the port behaviour. Running the installer as you described with PowerShell would have the installer pick up the session variable and use the port for UI shortcuts, but Backrest itself would still listen on the default port upon the next reboot.
Also, using : instead of 127.0.0.1: would cause Backrest to listen on all interfaces, thus exposing it to outside access.
The correct way to define a user variable persistently is described in this commit. I also made changes to the installer, including the language around the port. If Backrest supported port definition through a command-line switch (like --port=), then I could add an option to the installer to take user input and create the startup shortcut with the switch. The switch would have to be available in the backrest-windows-tray.exe since this is what starts the software. Not saying it is needed, just explaining what would have to be done to avoid the environment variable steps I described. Unfortunately, Windows doesn't support passing session variables through shortcuts, unless using cmd wrapper script, which is a bit ugly.
Custom port is probably an advanced feature not needed by most users. I think what we have now is very reasonable.