Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer is missing version and icon #481

Closed
auanasgheps opened this issue Sep 18, 2024 · 3 comments
Closed

Windows installer is missing version and icon #481

auanasgheps opened this issue Sep 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@auanasgheps
Copy link

Describe the bug
Windows installer is missing version and icon, showing no icon and a fake version: 00.00.00.00

To Reproduce
Install BackRest on Windows

Expected behavior
Whilst the icon is only a nice to have, having the real version displayed enables the user to know which version is installed using Settings/Control Panel, like almost all applications do.
Also, it will allow for submission to Windows Package Manager (winget)!

Screenshots
immagine

Platform Info

  • OS and Architecture: Windows 10 x64
  • Backrest Version: 00.00.00.00... joking, 1.5

Additional context
Add any other context about the problem here.

@auanasgheps auanasgheps added the bug Something isn't working label Sep 18, 2024
@garethgeorge
Copy link
Owner

garethgeorge commented Sep 19, 2024

Hey, thanks for making an issue to help track this. Definitely something that needs fixing and I think I've seen a few other issues discussing getting this on winget, we should definitely make that possible. My bandwidth with other refactors has been a bit sparse to get to it.

Adding a few notes on what needs to happen to fix this:

What needs to happen here is plumbing the tag that the github actions workflow is running on into the .nsis script here.

I believe nsis variables are just env vars -- it may be as simple as fixing https://github.com/garethgeorge/backrest/blob/main/scripts/generate-installers.sh#L3-L20 to pass through an env variable to the docker container e.g. VERSION= ...

I think the VERSION can be determined correctly in the github actions workflow by using ${{ github.ref_name }}" as the reference.

@brokoler
Copy link

I recognized the same issue on Windows 11 at multiple locations, using backrest v1.6.1.
The issue can be reproduced only via installing backrest v1.6.1 to any Windows system.

Desktop Icons:
grafik

Startmenu Icons:
{43E37E4E-8471-4472-B3F4-3D5634D60CFB}

@auanasgheps
Copy link
Author

auanasgheps commented Dec 4, 2024

immagine
immagine

Finally! The issue is resolved for me.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants