Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh: List pending nodes #368

Merged
merged 7 commits into from
Jan 17, 2024
Merged

ssh: List pending nodes #368

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77d7353
add test for nodes json output
petersutter Jan 16, 2024
6562344
rename to pendingMachine
petersutter Jan 16, 2024
6d3c1fb
initialize struct
petersutter Jan 16, 2024
c5d3f71
add comment why forbidden error is not logged
petersutter Jan 16, 2024
0cd9fc5
support pending machines
petersutter Jan 16, 2024
acebd86
add test
petersutter Jan 16, 2024
89bb9c0
PR feedback: rename to nodeMap
petersutter Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
initialize struct
  • Loading branch information
@petersutter
petersutter committed Jan 16, 2024
commit 6d3c1fbd61a9b8a571d719da76d9897aebdf8d06
7 changes: 4 additions & 3 deletions pkg/cmd/ssh/connect_information.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,10 @@ func NewConnectInformation(
var nodeList []Node

for _, node := range nodes {
n := Node{}
n.Name = node.Name
n.Status = "Ready"
n := Node{
Name: node.Name,
Status: "Ready",
}

if !isNodeReady(node) {
n.Status = "Not Ready"
Expand Down