Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target flags to target view command #289

Merged
merged 3 commits into from
May 11, 2023
Merged

Add target flags to target view command #289

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6619779
Add target flags tests for gtv
petersutter May 5, 2023
184fa62
Add target flags to gtv
petersutter May 5, 2023
0e2cd38
make gen-markdown
petersutter May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add target flags tests for gtv
  • Loading branch information
@petersutter
petersutter committed May 9, 2023
commit 661977966f816986b229b1c58cebce200b630ff6
51 changes: 45 additions & 6 deletions pkg/cmd/target/view_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,19 @@ package target_test

import (
"fmt"
"os"
"path/filepath"

"github.com/golang/mock/gomock"
"github.com/google/uuid"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"

internalfake "github.com/gardener/gardenctl-v2/internal/fake"
"github.com/gardener/gardenctl-v2/internal/util"
utilmocks "github.com/gardener/gardenctl-v2/internal/util/mocks"
cmdtarget "github.com/gardener/gardenctl-v2/pkg/cmd/target"
"github.com/gardener/gardenctl-v2/pkg/target"
targetmocks "github.com/gardener/gardenctl-v2/pkg/target/mocks"
)

var _ = Describe("Target View Command", func() {
Expand All @@ -27,19 +32,41 @@ var _ = Describe("Target View Command", func() {
var (
streams util.IOStreams
out *util.SafeBytesBuffer
factory *internalfake.Factory
targetProvider *internalfake.TargetProvider
ctrl *gomock.Controller
factory *utilmocks.MockFactory
manager *targetmocks.MockManager
targetProvider target.TargetProvider
currentTarget target.Target
sessionDir string
)

BeforeEach(func() {
ctrl = gomock.NewController(GinkgoT())
factory = utilmocks.NewMockFactory(ctrl)
manager = targetmocks.NewMockManager(ctrl)

factory.EXPECT().Manager().Return(manager, nil)

streams, _, out, _ = util.NewTestIOStreams()

targetFlags := target.NewTargetFlags("", "", "", "", false)
factory.EXPECT().TargetFlags().Return(targetFlags).AnyTimes()

sessionID := uuid.New().String()
sessionDir = filepath.Join(os.TempDir(), "garden", sessionID)
Expect(os.MkdirAll(sessionDir, os.ModePerm))
currentTarget = target.NewTarget(gardenName, projectName, "", shootName)
targetProvider = target.NewTargetProvider(filepath.Join(sessionDir, "target.yaml"), targetFlags)
Expect(targetProvider.Write(currentTarget)).To(Succeed())

manager.EXPECT().CurrentTarget().DoAndReturn(func() (target.Target, error) {
return targetProvider.Read()
})
})

JustBeforeEach(func() {
targetProvider = internalfake.NewFakeTargetProvider(currentTarget)
factory = internalfake.NewFakeFactory(nil, nil, nil, targetProvider)
AfterEach(func() {
Expect(os.RemoveAll(sessionDir)).To(Succeed())
ctrl.Finish()
})

It("should print current target information", func() {
Expand All @@ -48,6 +75,18 @@ var _ = Describe("Target View Command", func() {
Expect(cmd.RunE(cmd, nil)).To(Succeed())
Expect(out.String()).To(Equal(fmt.Sprintf("garden:\"%s\", project:\"%s\", shoot:\"%s\"", gardenName, projectName, shootName)))
})

Context("when target flags given", func() {
It("should print current target information", func() {
cmd := cmdtarget.NewCmdView(factory, streams)
cmd.SetArgs([]string{"--shoot", "myshoot2"})
Expect(cmd.Execute()).To(Succeed())
Expect(cmd.Flag("shoot").Value.String()).To(Equal("myshoot2"))

// here we need the real manager
Expect(out.String()).To(Equal(fmt.Sprintf("garden:\"%s\", project:\"%s\", shoot:\"%s\"", gardenName, projectName, "myshoot2")))
})
})
})

var _ = Describe("Target View Options", func() {
Expand Down